From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A990E1FF0E1 for ; Thu, 27 Aug 2026 17:48:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 47B8F213FC; Thu, 27 Aug 2026 17:48:07 +0200 (CEST) From: Jonas Theisen To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] fix #6251: api: Remove running tasks from errors output Date: Thu, 27 Aug 2026 17:47:32 +0200 Message-ID: <20260827154740.427154-1-j.theisen@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787845667261 X-SPAM-LEVEL: Spam detection results: 1 AWL -1.780 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_DBL_SPAM 5 Contains a spam URL listed in the Spamhaus DBL blocklist [tasks.rs] Message-ID-Hash: UL35QHY2JYT4BZFFZLQYVRH3RFCK4LQQ X-Message-ID-Hash: UL35QHY2JYT4BZFFZLQYVRH3RFCK4LQQ X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently running tasks are returned by the PBS API in the query for errored tasks. This patch adds an additional condition to filter out running tasks when queried for errored tasks. Reported in https://forum.proxmox.com/threads/163872/, https://forum.proxmox.com/threads/185999/ and https://bugzilla.proxmox.com/show_bug.cgi?id=6251 Signed-off-by: Jonas Theisen --- src/api2/node/tasks.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/api2/node/tasks.rs b/src/api2/node/tasks.rs index 96f5e080f..4786820a3 100644 --- a/src/api2/node/tasks.rs +++ b/src/api2/node/tasks.rs @@ -610,6 +610,7 @@ pub fn list_tasks( (Some(state), Some(filters)) if !filters.contains(&tasktype(state)) => { continue; } + (None, _) if errors => continue, (None, Some(_)) => continue, _ => {} } -- 2.47.3