From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 2CA721FF0C1 for ; Wed, 26 Aug 2026 12:38:00 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BC7C6213A7; Wed, 26 Aug 2026 12:37:59 +0200 (CEST) From: Elias Huhsovitz To: d.csapak@proxmox.com Subject: [PATCH access-control] rpc: do not check malformed acl path Date: Wed, 26 Aug 2026 12:37:52 +0200 Message-ID: <20260826103752.115037-1-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <8eff67e8-ac88-4b7d-a90d-de32644d1d95@proxmox.com> References: <8eff67e8-ac88-4b7d-a90d-de32644d1d95@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787740644059 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.425 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_MAILER 2 Automated Mailer Tag Left in Email POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: O4X56B5F6UKQQVC2DPHWMZT6GWW5BE3Z X-Message-ID-Hash: O4X56B5F6UKQQVC2DPHWMZT6GWW5BE3Z X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: e.huhsovitz@proxmox.com, pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Elias Huhsovitz --- Thank you for the feedback. I looked into this a bit more and provided an experimental patch as a reference. The Problem ----------- The core problem is indeed the colon ':', which makes sense. I did some further testing and the same error occurs when sending a request to the enpoint: GET /cluster/mapping/pci/{id} It outputs the errors: pveproxy[42711]: Failed to normalize '/mapping/pci/0000:01:00.0' pveproxy[42711]: internal error: ACL check called for undefined ACL path! pveproxy[42711]: Use of uninitialized value $path in concatenation (.) or string at /usr/share/perl5/PVE/RPCEnvironment.pm line 325. Mismatch --------- I think explicitely checking the permissions in the api handler itself will work, but to my understanding there is an underlying mismatch: The API schema explicitly allows colons (for raw PCI IDs), but the ACL path normalizer explicitly rejects them. Proposed solution ----------------- IMHO providing explicit permissions on a raw PCI ID like 0000:01:00.0 instead of a mapping should not happen (i think) and should not be checked. What is your opinion on simply not checking invalid ACL paths? This would cause a more graceful failure. Caveats ------- (I fear that such a check might causes problems in existing systems, that rely on "invalid" ACL paths. But i would love to hear your input on this) Side note --------- What aboud allowing encoded PCI IDs instead? e.g., GET /nodes/lisa/hardware/pci/0000%3A01%3A00.0 Summary of changes ------------------ src/PVE/RPCEnvironment.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm index 7591aa9..61ef28b 100644 --- a/src/PVE/RPCEnvironment.pm +++ b/src/PVE/RPCEnvironment.pm @@ -487,7 +487,11 @@ sub exec_api2_perm_check { } my $path = PVE::Tools::template_replace($tmplpath, $param); my $normpath = PVE::AccessControl::normalize_path($path); - warn "Failed to normalize '$path'\n" if !defined($normpath) && defined($path); + + if (!defined($normpath)) { + warn "Failed to normalize ACL path '$path'\n" if defined($path); + return 0; + } return $self->check_full($username, $normpath, $privs, $any, $noerr); } elsif ($test eq 'userid-group') { -- 2.47.3