From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E8CF11FF0C1 for ; Wed, 26 Aug 2026 09:50:01 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 93DCD212FC; Wed, 26 Aug 2026 09:49:55 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 4/4] partially fix #7801: ui: hardware view: warn about problematic virtio versions Date: Wed, 26 Aug 2026 09:49:35 +0200 Message-ID: <20260826074935.78437-5-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260826074935.78437-1-n.frey@proxmox.com> References: <20260826074935.78437-1-n.frey@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.878 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: XTJ52O3GBHPL65MAM4WBDWHYODISKNHV X-Message-ID-Hash: XTJ52O3GBHPL65MAM4WBDWHYODISKNHV X-MailFrom: nfrey@miso.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: based on whether the ostype is windows or not. extends the `editorFactory` to allow extraOptions to be a callback to allow for lazy evaluation. this is needed as 'ostype' is not yet instantiated when eagerly evaluating. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7801 Signed-off-by: Nicolas Frey --- changes since v1: * actually lazily evaluate the ostype by putting it in the function body that gets returned (i.e. the factory) * add missing warnVirtio to commonOpts www/manager6/qemu/HardwareView.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index e6c02299..9e900746 100644 --- a/www/manager6/qemu/HardwareView.js +++ b/www/manager6/qemu/HardwareView.js @@ -436,6 +436,7 @@ Ext.define('PVE.qemu.HardwareView', { listeners: { destroy: () => me.reload(), }, + warnVirtio: PVE.Utils.is_windows(me.getObjectValue('ostype')), }; if (Ext.isString(editor)) { @@ -805,7 +806,6 @@ Ext.define('PVE.qemu.HardwareView', { }; let editorFactory = (classPath, extraOptions) => { - extraOptions = extraOptions || {}; return () => Ext.create(`PVE.qemu.${classPath}`, { autoShow: true, @@ -816,7 +816,7 @@ Ext.define('PVE.qemu.HardwareView', { }, isAdd: true, isCreate: true, - ...extraOptions, + ...(Ext.isFunction(extraOptions) ? extraOptions() : extraOptions || {}), }); }; @@ -847,7 +847,9 @@ Ext.define('PVE.qemu.HardwareView', { text: gettext('CD/DVD Drive'), iconCls: 'pve-itype-icon-cdrom', disabled: !caps.vms['VM.Config.CDROM'], - handler: editorFactory('CDEdit'), + handler: editorFactory('CDEdit', () => ({ + warnVirtio: PVE.Utils.is_windows(me.getObjectValue('ostype')), + })), }, { text: gettext('Network Device'), -- 2.47.3