From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 880EB1FF0B7 for ; Tue, 25 Aug 2026 15:55:50 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DBBD421692; Tue, 25 Aug 2026 15:55:08 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v4 5/7] pci: preparation: mdev: only generate uuid once Date: Tue, 25 Aug 2026 15:54:50 +0200 Message-ID: <20260825135502.3971930-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260825135502.3971930-1-d.csapak@proxmox.com> References: <20260825135502.3971930-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.720 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WWJSO36PCJXSTJSSONQVIDCRWOGFMLWB X-Message-ID-Hash: WWJSO36PCJXSTJSSONQVIDCRWOGFMLWB X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In `prepare_pci_device` we already generate a uuid for the mdev. Later, for NVIDIA vGPU, we need the uuid again to add it to the qemu cmdline. Instead of generating it twice, return it from `prepare_pci_device` and reuse that if we can. If the device uses the modern nvidia vgpu stack, we don't need to create a mdev, so generate the fallback uuid in `prepare_pci_devices`. Signed-off-by: Dominik Csapak --- src/PVE/QemuServer/PCI.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer/PCI.pm b/src/PVE/QemuServer/PCI.pm index f7167dcc..5d2fdabb 100644 --- a/src/PVE/QemuServer/PCI.pm +++ b/src/PVE/QemuServer/PCI.pm @@ -739,7 +739,8 @@ sub prepare_pci_devices { # nvidia vgpu needs a uuid as qemu parameter if (!defined($uuid) && $chosen_mdev->{vendor} =~ m/^(0x)?10de$/) { - $uuid = PVE::QemuServer::PCI::Mdev::generate_mdev_uuid($vmid, $index); + $uuid = $chosen_mdev->{uuid} + // PVE::QemuServer::PCI::Mdev::generate_mdev_uuid($vmid, $index); } } @@ -760,6 +761,7 @@ sub prepare_pci_device { } elsif (my $mdev = $device->{mdev}) { my $uuid = PVE::QemuServer::PCI::Mdev::generate_mdev_uuid($vmid, $index); PVE::QemuServer::PCI::Mdev::pci_create_mdev_device($pciid, $uuid, $mdev); + $info->{uuid} = $uuid; } else { die "can't unbind/bind PCI group to VFIO '$pciid'\n" if !PVE::SysFSTools::pci_dev_group_bind_to_vfio($pciid); -- 2.47.3