From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 0E2B21FF0B7 for ; Tue, 25 Aug 2026 15:54:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AA0F3214B6; Tue, 25 Aug 2026 15:54:36 +0200 (CEST) From: Shan Shaji To: yew-devel@lists.proxmox.com Subject: [PATCH proxmox-yew-comp] fix #7932: add missing uptime to the GUI Date: Tue, 25 Aug 2026 15:54:25 +0200 Message-ID: <20260825135425.329949-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787666043687 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.402 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MH4TWFZZXK42MVDKLZHSQTBGJWPUP4RZ X-Message-ID-Hash: MH4TWFZZXK42MVDKLZHSQTBGJWPUP4RZ X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Previously, the uptime was not displayed in Proxmox Datacenter Manager. This fixes the issue by wiring the property already available from the /status endpoint into the UI. Signed-off-by: Shan Shaji --- src/node_status_panel.rs | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/src/node_status_panel.rs b/src/node_status_panel.rs index ec17a94..d1a02c2 100644 --- a/src/node_status_panel.rs +++ b/src/node_status_panel.rs @@ -8,13 +8,13 @@ use pwt::widget::form::DisplayField; use yew::virtual_dom::{VComp, VNode}; use pwt::prelude::*; -use pwt::widget::{error_message, Fa, Panel, Row, Tooltip}; +use pwt::widget::{Container, Fa, Panel, Row, Tooltip, error_message}; use pwt::widget::{Button, Dialog}; use pwt_macros::builder; use proxmox_node_status::{NodePowerCommand, NodeStatus}; -use crate::utils::copy_text_to_clipboard; +use crate::utils::{copy_text_to_clipboard, format_duration_human}; use crate::{ http_get, http_post, node_info, ConfirmButton, LoadableComponent, LoadableComponentContext, LoadableComponentMaster, LoadableComponentScopeExt, LoadableComponentState, @@ -146,6 +146,26 @@ impl ProxmoxNodeStatusPanel { } } +fn uptime_html(node_status: Option<&node_info::NodeStatus>) -> Option { + let uptime = match node_status { + Some(node_info::NodeStatus::Pve(node_status)) => node_status + .additional_properties + .get("uptime") + .and_then(|uptime| uptime.as_u64()) + .unwrap_or_default(), + Some(node_info::NodeStatus::Pbs(node_status)) => node_status.uptime, + Some(node_info::NodeStatus::Common(node_status)) => node_status.uptime, + None => 0 + }; + + if uptime == 0 { + return None; + } + + let uptime_string = tr!("(Uptime: {})", format_duration_human(uptime as f64)); + Some(Container::from_tag("span").with_child(uptime_string).into()) +} + impl LoadableComponent for ProxmoxNodeStatusPanel { type Message = Msg; type ViewState = ViewState; @@ -229,6 +249,7 @@ impl LoadableComponent for ProxmoxNodeStatusPanel { .gap(2) .with_child(Fa::new("book")) .with_child(tr!("Node Status")) + .with_optional_child(uptime_html(status.as_ref())) .into_html(), ) .with_child(node_info(status)) -- 2.47.3