From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CF88A1FF0B7 for ; Tue, 25 Aug 2026 13:02:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 17981214DD; Tue, 25 Aug 2026 13:02:43 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Subject: [PATCH manager 0/4] fix #7801: ui: warn about problematic virtio versions on iso select Date: Tue, 25 Aug 2026 13:02:34 +0200 Message-ID: <20260825110238.215790-1-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -1.187 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: 5DZJYBWXY5OOMVBJMNFVZYHIVDTEGNT5 X-Message-ID-Hash: 5DZJYBWXY5OOMVBJMNFVZYHIVDTEGNT5 X-MailFrom: nfrey@miso.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: fixes #7801 by scanning for virtio filename regex and warning the user if the version has known issues attributed to it [0]. I tried the following approaches to warn the user: - via a (quite intrusive) pop-up - a warning box after the iso selector - an inline hoverable icon on the selector field I felt the second approach resulted in the best UX, so I went with that in this series. If we have any better/more standard way to warn about things like these which I missed, please LMK! [0] https://pve.proxmox.com/wiki/Windows_VirtIO_Drivers pve-manager: Nicolas Frey (4): ui: iso selector: add option to warn about virtio versions with issues ui: cd edit: add `warnVirtio` option to pass to iso selector partially fix #7801: ui: ospanel: warn about problematic virtio versions partially fix #7801: ui: hardware view: warn about problematic virtio versions www/manager6/form/IsoSelector.js | 68 ++++++++++++++++++++++++++++++- www/manager6/qemu/CDEdit.js | 4 ++ www/manager6/qemu/HardwareView.js | 6 ++- www/manager6/qemu/OSPanel.js | 1 + 4 files changed, 75 insertions(+), 4 deletions(-) Summary over all repositories: 4 files changed, 75 insertions(+), 4 deletions(-) -- Generated by murpp 0.12.1