From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C1BB01FF0C1 for ; Tue, 25 Aug 2026 10:10:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0BD97217CB; Tue, 25 Aug 2026 10:09:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azharul.com; s=t28hkp5; t=1787283745; x=1787888545; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XURI6B56G+syMsfQrZwopqzKtpQocmN0M1iwWVp4V3g=; b=XHgJSoHC6AbyIdEXV1vQsPQAw2tCO0Ydcd8UI4Ab4MHg+oG+e7skN/g7OBdpwtfwA7 N2Vj4/zdjpMNop4i5drCMo3qKpMeT4jt+PmchNkVFaUR8a9VxDbEdQyiFx7YoYeOyxMN mH/y/W3ODXBNwpuQPiuXiKGZHfzMZVGXK2r9B8gWdd/NRw2Lfcka+zMDwUdKCjIRSVQ6 YOxrS9uoMIcv8REIQM0y/rLTwy08Gc/fP6a8Ui/JrAUMpRJZyM5VfLp5fAf/jhAKOw4M 1CXT+tjGrThBqVms6qj8AA2KfcPP2vqwmuQpVeg7V7UGOJDZEQby7dK4PWChZwd/WyHx usJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787283745; x=1787888545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XURI6B56G+syMsfQrZwopqzKtpQocmN0M1iwWVp4V3g=; b=oz4RFQGb4Q1+8JqN43/0NkcZskKpFCrGLceTAxfUwGAhAYdGeXXra3UPQ8C7xJ3xJA DKj1P0WNgE8zXsBb9y1XggmhHwRwIPDq4T7Ogf+JI1c3MYO6rCWJDZ8VX/iu1TxKUjPe N/EvTmPRc7hPP/bRSsPYYhj91flytBnQKGIsZE/fxkpYZqDHaYBFvI9Y60PI9tHRwjvd yO1PStWpRC0A52ax6mcbNe+TDgZwX23yb8XDcWPz4eUVzFoh1x4LbAYVZ7TtNerFe4u7 uVFj5ECwSiI+4mzJJKUH73v9lynASRePkprkcYPO5LLcTVZRc4GbYTNfxqG6UV74ZJK1 RtGQ== X-Gm-Message-State: AOJu0Yxn+LkmOY8/fjmzZoMBxxeiKVAc5mejl0J4jCX1y9EVjQ9jEQmX mtexaHkQ7G+1dQcRKVseqTGydD8/0kO98J17CShePiJEv6HG9a0lZIKMF9+U3gOlN2O/NZymOgQ cQzEHag== X-Gm-Gg: AR+sD13X9s3bBlJZU9YfYao6aiLKB8t4I2w1x5CaIlu5VUlzcIMAhOp1FeYuGCcZjhP BpdklHtjogu2z2L8rn8a1X5GFle+SeLv/ss5cNCKPILi1STerX/c0ABfJvMg7nGT0Rbzf2G5XJC qqSBoHG3lUtkt7Qre5fx7/Y9yTRZb/ujjJBLbemN28vdbVqKSewfpcWHNPgJEeMu5F8LmO/J9o2 iFh4nhrJvkojp+wET46A7uVBRpjaFDs8dArh6chaWO8T563CSV85mr9MJKaROipLQI0mwJK3a+D sAEDidxcJwa3PUJyL86DV0uG/l32bBCiNdoFfutQDlR5Kie5p1e+vMrjbRuYjDPJHyvlZ5l7ZFc a7tmnFMpxlEk88ieelZ1bRvp2fc5jXzWy4Os+Pbg3rWG0/T4ptcz+ZmigDN1PydQaNtvyYx9kgX RDOlav3xDFl9dn02CAUyE9vp2SHd6rbtMEPt15A2mAE1t/CrOsEhBGy5+CEsO9ZCXymQ5UJrQ1F bB0DFNl7gtziFciaVbP27kgkZ3/ZU3ZPGJtNULgPr0OmEOOH0pIGVR1v0ZZSStTp2i4/0envP6E XDp6+Z6wD+6GCSzM1POsAYHEMGXTUKRK22zxZh9Y7BAwkdtZ3FFP X-Received: by 2002:a05:620a:1b84:b0:92e:5cfd:154e with SMTP id af79cd13be357-93739466d85mr306767485a.14.1787283718638; Thu, 20 Aug 2026 20:41:58 -0700 (PDT) From: Azharul Haque To: pve-devel@lists.proxmox.com Subject: [PATCH v3 00/10] app: implement OpenID Connect (OAuth) realm login (#4281) Date: Thu, 20 Aug 2026 23:41:37 -0400 Message-ID: <20260821034147.30194-1-haque@azharul.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260810144713.75806-1-haque@azharul.com> References: <20260810144713.75806-1-haque@azharul.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.128 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: haque@azharul.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: IITFM656MYE22VFFZJUSG5GXZW3JLRZ3 X-Message-ID-Hash: IITFM656MYE22VFFZJUSG5GXZW3JLRZ3 X-Mailman-Approved-At: Tue, 25 Aug 2026 10:09:15 +0200 CC: haque@azharul.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The native Flutter "Proxmox VE Companion" app never implemented OpenID Connect / OAuth realm login (bug #4281[0]): selecting an OAuth realm just showed username/password fields that could never work. v3: addresses review feedback on v2, still as a single combined series across the three affected repositories: - dart-api-client: PveAccessDomainModel.type is now a built_value EnumClass (PveAccessDomainType) instead of a plain String, and the OpenID ticket-parsing helper's regex/dedup issue is fixed. - login-manager: the single large "add OpenID Connect login flow" patch is split into five, dependency, _finishLogin refactor, password-form widget extraction, the OpenID feature itself, and the pre-existing Continue-button fix, and print()/print(trace) calls copied into the new OpenID error handling are removed. - flutter-frontend: the manifest change is split into three, generated-file regeneration, the taskAffinity tweak, and the CallbackActivity registration itself. - Both repos' "rename the callback scheme" follow-up patches from v2 are gone entirely: the final scheme (com.proxmox.app, further shortened per your follow-up on the login-manager v2 3/3 patch) is now introduced directly wherever it first appears. - All lockfiles/generated files are regenerated against Flutter 3.41 / Dart 3.11 to match this project's toolchain, rather than the newer local Flutter version v2 was inadvertently built with. Verified end-to-end against a real PVE server with an Authentik OIDC realm, on both Android and iOS, plus flutter analyze/test/format under Flutter 3.41 across all three repos, plus a real Android Gradle build of the modified manifest. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4281 Azharul Haque (10): fix #4281: access: add `type` property to `PveAccessDomainModel` fix #4281: access: add OpenID Connect auth-url/login helpers fix #4281: deps: add flutter_web_auth_2 dependency refactor: ui: factor out shared login tail into _finishLogin refactor: ui: split password form into its own widget fix #4281: ui: add OpenID Connect login flow to login form fix #4281: ui: fix stale Continue button state on realm switch chore: regenerate plugin registrant for flutter_web_auth_2 fix #4281: android: set taskAffinity="" on MainActivity fix #4281: android: register OpenID Connect callback activity -- 2.50.1 (Apple Git-155)