From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 3E1941FF0AD for ; Thu, 20 Aug 2026 15:11:14 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EA0AB2159D; Thu, 20 Aug 2026 15:11:11 +0200 (CEST) From: Christian Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH v4 qemu-server 2/3] pbs-restore: set 'no-cache' on block devices backed by zfspool Date: Thu, 20 Aug 2026 15:10:48 +0200 Message-ID: <20260820131049.374072-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260820131049.374072-1-c.ebner@proxmox.com> References: <20260820131049.374072-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787231442249 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.744 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OBSO6D5EV76XLIB5GGTKC3QNX2UCRFEO X-Message-ID-Hash: OBSO6D5EV76XLIB5GGTKC3QNX2UCRFEO X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Skip the host page cache for restores on zvols, as page writeback after filling the buffers can cause I/O delay on other ZFS-backed VMs on certain setups, as reported in enterprise support and reproduced internally. The restored data is not to be read back from cache during restore anyways. Keep for other storage types for now to reduce regression potential. Version bump in d/control assures feature compatibility for pbs-restore. Signed-off-by: Christian Ebner --- changes since version 3: - drop package version comparison checks - bump d/control dependency for pve-qemu-kvm debian/control | 2 +- src/PVE/QemuServer.pm | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 97049e1d..a9949d5a 100644 --- a/debian/control +++ b/debian/control @@ -61,7 +61,7 @@ Depends: conntrack, pve-edk2-firmware-ovmf (>= 4.2025.05-2) [amd64], pve-firewall (>= 6.0.3), pve-ha-manager (>= 5.0.3), - pve-qemu-kvm (>= 7.1~), + pve-qemu-kvm (>= 11.0.3-3), python3-virt-firmware, socat, swtpm, diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 2f43faa7..317aeaac 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -7090,6 +7090,13 @@ sub restore_proxmox_backup_archive { if (PVE::Storage::volume_has_feature($storecfg, 'sparseinit', $volid)) { push @$pbs_restore_cmd, '--skip-zero'; } + my ($target_storeid) = PVE::Storage::parse_volume_id($volid, 1); + my $target_scfg = PVE::Storage::storage_config($storecfg, $target_storeid); + + if ($target_scfg->{type} eq 'zfspool') { + #TODO: potentially extend to other storage types + push @$pbs_restore_cmd, '--no-cache'; + } my $dbg_cmdstring = PVE::Tools::cmd2string($pbs_restore_cmd); print "restore proxmox backup image: $dbg_cmdstring\n"; -- 2.47.3