From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EABE81FF0B2 for ; Thu, 20 Aug 2026 11:06:51 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D0FB32157E; Thu, 20 Aug 2026 11:06:06 +0200 (CEST) From: Christian Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH v3 qemu-server 5/6] pbs-restore: set 'no-cache' on block devices backed by zfspool Date: Thu, 20 Aug 2026 11:05:27 +0200 Message-ID: <20260820090528.117853-6-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260820090528.117853-1-c.ebner@proxmox.com> References: <20260820090528.117853-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787216718927 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.761 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TIWVIYYNSWIPC4Z3NIHPWTQ73FLSHRLR X-Message-ID-Hash: TIWVIYYNSWIPC4Z3NIHPWTQ73FLSHRLR X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Skip the host page cache for restores on zvols, as page writeback after filling the buffers can cause I/O delay on other ZFS-backed VMs on certain setups, as reported in enterprise support and reproduced internally. The restored data is not to be read back from cache during restore anyways. Keep for other storage types for now to reduce regression potential. Signed-off-by: Christian Ebner --- changes since version 2: - adapt to new helper name and interface src/PVE/QemuServer.pm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 2f43faa7..21924988 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -7090,6 +7090,16 @@ sub restore_proxmox_backup_archive { if (PVE::Storage::volume_has_feature($storecfg, 'sparseinit', $volid)) { push @$pbs_restore_cmd, '--skip-zero'; } + my ($target_storeid) = PVE::Storage::parse_volume_id($volid, 1); + my $target_scfg = PVE::Storage::storage_config($storecfg, $target_storeid); + + if ( + PVE::QemuServer::Helpers::binary_package_version_at_least(11, 0, 3, 3) + && $target_scfg->{type} eq 'zfspool' + ) { + #TODO: potentially extend to other storage types + push @$pbs_restore_cmd, '--no-cache'; + } my $dbg_cmdstring = PVE::Tools::cmd2string($pbs_restore_cmd); print "restore proxmox backup image: $dbg_cmdstring\n"; -- 2.47.3