From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BCF4C1FF0A7 for ; Wed, 19 Aug 2026 15:51:30 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8DD7B2154C; Wed, 19 Aug 2026 15:51:27 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] clone: drop the IPAM entries of a clone that failed Date: Wed, 19 Aug 2026 15:51:20 +0200 Message-ID: <20260819135120.933223-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787147459362 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.216 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FB3T44PHK5J5656PEY4TSLSCOX25BUBM X-Message-ID-Hash: FB3T44PHK5J5656PEY4TSLSCOX25BUBM X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The clone puts its addresses on record before the last steps that can still fail, and the cleanup afterwards took back the disks, the firewall config and the configuration itself but left those behind. Signed-off-by: Hannes Laimer --- src/PVE/API2/Qemu.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 71247eec..b17f9bce 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -4720,6 +4720,9 @@ __PACKAGE__->register_method({ warn $@ if $@; } + eval { PVE::QemuServer::Network::delete_ifaces_ipams_ips($newconf, $newid) }; + warn $@ if $@; + PVE::Firewall::remove_vmfw_conf($newid); unlink $conffile; # avoid races -> last thing before die -- 2.47.3