all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v2 8/9] ui: firewall: ipset: add controls to update/delete references on edit
Date: Tue, 18 Aug 2026 15:34:12 +0200	[thread overview]
Message-ID: <20260818133413.450776-9-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20260818133413.450776-1-a.bied-charreton@proxmox.com>

Add the shared 'update-references' selector to the update dialog, so a
rename can (force-)update all references to the ipset, and replace the
plain remove button with a confirmation dialog offering to delete
referencing rules along with the ipset.

StdRemoveButton cannot pass the extra 'delete-references' parameter, so
the remove button is switched to a plain button that opens the shared
FirewallDeleteReferences dialog.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/panel/IPSet.js | 31 ++++++++++++++++++++++++++++---
 1 file changed, 28 insertions(+), 3 deletions(-)

diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index 9e0203a0..5c7340a7 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
@@ -91,6 +91,16 @@ Ext.define('PVE.IPSetList', {
                         value: rec.data.comment,
                         fieldLabel: gettext('Comment'),
                     },
+                    {
+                        xtype: 'pveFirewallUpdateReferences',
+                        noTip: gettext(
+                            'Do not update referencing rules when renaming this IPSet. Note that this will render any reference to this IPSet invalid.',
+                        ),
+                        yesTip: gettext('Update referencing rules to point to the new IPSet name.'),
+                        forceTip: gettext(
+                            'Update referencing rules to point to the new IPSet name, overwriting any pre-existing IPSet with the target name. Can be used in case a failed rename left the cluster configuration in a partially-updated state.',
+                        ),
+                    },
                 ],
             });
             win.show();
@@ -134,11 +144,26 @@ Ext.define('PVE.IPSetList', {
             },
         });
 
-        me.removeBtn = Ext.create('Proxmox.button.StdRemoveButton', {
+        me.removeBtn = Ext.create('Proxmox.button.Button', {
+            text: gettext('Remove'),
+            disabled: true,
+            dangerous: true,
             enableFn: (rec) => canEdit,
             selModel: sm,
-            baseurl: me.base_url + '/',
-            callback: reload,
+            handler: function (btn, event, rec) {
+                Ext.create('PVE.window.FirewallDeleteReferences', {
+                    item: { id: rec.data.name },
+                    url: me.base_url + '/' + rec.data.name,
+                    text: Ext.String.format(
+                        gettext("Are you sure you want to remove IPSet '{0}'?"),
+                        rec.data.name,
+                    ),
+                    refsTip: gettext(
+                        'Delete all firewall rules referencing this IPSet. If left unchecked, some firewall configurations may end up with dangling references.',
+                    ),
+                    apiCallDone: reload,
+                }).show();
+            },
         });
 
         Ext.apply(me, {
-- 
2.47.3




  parent reply	other threads:[~2026-08-18 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 13:34 [PATCH firewall/manager v2 0/9] allow updating references when renaming/deleting firewall objects Arthur Bied-Charreton
2026-08-18 13:34 ` [PATCH pve-firewall v2 1/9] api: helpers: add helper to update firewall object references Arthur Bied-Charreton
2026-08-18 13:34 ` [PATCH pve-firewall v2 2/9] api: ipset: add option to update references on edit Arthur Bied-Charreton
2026-08-18 13:34 ` [PATCH pve-firewall v2 3/9] api: ipset: add option to GC references on delete Arthur Bied-Charreton
2026-08-18 13:34 ` [PATCH pve-firewall v2 4/9] api: aliases: add option to update references on edit Arthur Bied-Charreton
2026-08-18 13:34 ` [PATCH pve-firewall v2 5/9] api: aliases: add option to GC references on delete Arthur Bied-Charreton
2026-08-18 13:34 ` [PATCH pve-firewall v2 6/9] firewall: tests: add tests for object reference update logic Arthur Bied-Charreton
2026-08-18 13:34 ` [PATCH pve-manager v2 7/9] ui: firewall: add common widgets for deleting and updating references Arthur Bied-Charreton
2026-08-18 13:34 ` Arthur Bied-Charreton [this message]
2026-08-18 13:34 ` [PATCH pve-manager v2 9/9] ui: firewall: aliases: add controls to update/delete references on edit Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818133413.450776-9-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal