From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 65C4A1FF0A7 for ; Tue, 18 Aug 2026 15:34:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E0ED22157F; Tue, 18 Aug 2026 15:34:18 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-firewall v2 3/9] api: ipset: add option to GC references on delete Date: Tue, 18 Aug 2026 15:34:07 +0200 Message-ID: <20260818133413.450776-4-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260818133413.450776-1-a.bied-charreton@proxmox.com> References: <20260818133413.450776-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.747 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: L2M5BPAKKBLBSN73F6XG64ECOUC7N6TG X-Message-ID-Hash: L2M5BPAKKBLBSN73F6XG64ECOUC7N6TG X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Deleting an ipset referenced by rules or security groups leaves dangling references, which the firewall fails to parse and drops. Add a 'delete-references' option to the delete endpoint to allow removing such references. For cluster ipsets, this also covers all downstream configs (host, guest and vnet). Signed-off-by: Arthur Bied-Charreton --- src/PVE/API2/Firewall/IPSet.pm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/PVE/API2/Firewall/IPSet.pm b/src/PVE/API2/Firewall/IPSet.pm index 0d802aa..ba233b7 100644 --- a/src/PVE/API2/Firewall/IPSet.pm +++ b/src/PVE/API2/Firewall/IPSet.pm @@ -2,6 +2,7 @@ package PVE::API2::Firewall::IPSetBase; use strict; use warnings; +use PVE::Firewall::Helpers qw(update_refs get_object_spec); use PVE::Exception qw(raise raise_param_exc); use PVE::JSONSchema qw(get_standard_option); @@ -140,6 +141,12 @@ sub register_delete_ipset { optional => 1, description => 'Delete all members of the IPSet, if there are any.', }; + $properties->{'delete-references'} = { + type => 'boolean', + optional => 1, + description => 'Delete dangling references after deleting the IPSet.', + default => 0, + }; $class->register_method({ name => 'delete_ipset', @@ -166,6 +173,11 @@ sub register_delete_ipset { die "IPSet '$param->{name}' is not empty\n" if scalar(@$ipset) && !$param->{force}; + if ($param->{'delete-references'}) { + my $spec = get_object_spec('ipset'); + update_refs($fw_conf, $spec, $param->{name}, undef, $class->rule_env()); + } + $class->save_ipset($param, $fw_conf, undef); }, -- 2.47.3