From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id F09971FF0EA for ; Thu, 13 Aug 2026 17:06:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 75E8F218CF; Thu, 13 Aug 2026 17:06:02 +0200 (CEST) From: Thomas Ellmenreich To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 4/4] fix #7747: openid: allow non HTTP schemes in redirect URL Date: Thu, 13 Aug 2026 17:05:51 +0200 Message-ID: <20260813150551.415237-5-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260813150551.415237-1-t.ellmenreich@proxmox.com> References: <20260813150551.415237-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786633540073 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.114 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RQ55R2XCGHTVUBWDNNWQ4FRYMBM4MISN X-Message-ID-Hash: RQ55R2XCGHTVUBWDNNWQ4FRYMBM4MISN X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Loosen validation on redirect URLs for OpenID authentication to also allow other valid schemes that are not HTTP or HTTPS. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7747 Signed-off-by: Thomas Ellmenreich --- lib/pdm-api-types/src/lib.rs | 1 + server/src/api/access/openid.rs | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/pdm-api-types/src/lib.rs b/lib/pdm-api-types/src/lib.rs index 89d1b4ad..6ddeab5d 100644 --- a/lib/pdm-api-types/src/lib.rs +++ b/lib/pdm-api-types/src/lib.rs @@ -71,6 +71,7 @@ pub use proxmox_schema::api_types::HTTP_URL_SCHEMA; pub use proxmox_schema::api_types::MULTI_LINE_COMMENT_SCHEMA; pub use proxmox_schema::api_types::NODE_SCHEMA; pub use proxmox_schema::api_types::SINGLE_LINE_COMMENT_FORMAT; +pub use proxmox_schema::api_types::URL_SCHEMA; pub use proxmox_schema::api_types::{ BLOCKDEVICE_DISK_AND_PARTITION_NAME_SCHEMA, BLOCKDEVICE_NAME_SCHEMA, }; diff --git a/server/src/api/access/openid.rs b/server/src/api/access/openid.rs index 5048fde3..caa065f3 100644 --- a/server/src/api/access/openid.rs +++ b/server/src/api/access/openid.rs @@ -18,9 +18,7 @@ use proxmox_router::{ use proxmox_schema::{ApiType, ObjectSchema, ParameterSchema, StringSchema, api}; use proxmox_sortable_macro::sortable; -use pdm_api_types::{ - HTTP_URL_SCHEMA, OPENID_DEFAULT_SCOPE_LIST, OpenIdRealmConfig, REALM_ID_SCHEMA, -}; +use pdm_api_types::{OPENID_DEFAULT_SCOPE_LIST, OpenIdRealmConfig, REALM_ID_SCHEMA, URL_SCHEMA}; use pdm_buildcfg::PDM_RUN_DIR_M; use crate::auth; @@ -252,7 +250,7 @@ fn create_ticket_http_only( schema: REALM_ID_SCHEMA, }, "redirect-url": { - schema: HTTP_URL_SCHEMA, + schema: URL_SCHEMA, }, }, }, -- 2.47.3