[PATCH datacenter-manager/proxmox 0/4] fix #7747: OpenID: allow non HTTP scheme in redirect URL

[Thomas Ellmenreich <t.ellmenreich@proxmox.com>]

As reported in this bug: [1], PDM's '/access/openid/auth-url' endpoint only
accepts URL's that either have a HTTP or HTTPS scheme. Also as the user
mentions, this is a problem for native app authentication flows that might
want to redirect back to the application after successful authentication.

Since PVE already accepts redirect URLs with any scheme, this series also
extends PDM's validation to allow other schemes.

Implementation
--------------

To avoid duplicated regex strings, part of the original HTTP_URL_REGEX
was refactored out, and then reused for the new URL_REGEX.

Testing
-------

I tested this with a simple curl request to both PDM's and PVE's 'auth-url'
endpoints. Providing a HTTP and non HTTP scheme, to see where the process
fails.

```
curl -o - --data '{"realm":"myrealm","redirect-url":"https://pdm1:8443"}' \
    --header 'Content-Type: application/json;charset=UTF-8' \
    -k https://pdm1:8443/api2/extjs/access/openid/auth-url | jq
```

[1]: https://bugzilla.proxmox.com/show_bug.cgi?id=7747


proxmox:

Thomas Ellmenreich (3):
  api-types: reorganise unit tests
  api-types: refactor HTTP_URL_REGEX construction
  api-types: add a scheme generic URL regex

 pbs-api-types/src/lib.rs        |   1 +
 proxmox-schema/src/api_types.rs | 128 ++++++++++++++++++++++++--------
 2 files changed, 97 insertions(+), 32 deletions(-)


proxmox-datacenter-manager:

Thomas Ellmenreich (1):
  fix #7747: openid: allow non HTTP schemes in redirect URL

 lib/pdm-api-types/src/lib.rs    | 1 +
 server/src/api/access/openid.rs | 6 ++----
 2 files changed, 3 insertions(+), 4 deletions(-)


Summary over all repositories:
  4 files changed, 100 insertions(+), 36 deletions(-)

-- 
Generated by murpp 0.12.0