From: Shan Shaji <s.shaji@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox{-backup,} v3 0/3] partially fix #6933: add option to specify zfs recordsize
Date: Wed, 12 Aug 2026 16:40:26 +0200 [thread overview]
Message-ID: <20260812144029.129970-1-s.shaji@proxmox.com> (raw)
The option to specify the `recordsize` was previously available neither
in the UI nor in the CLI. Users had to configure it manually using the
ZFS CLI. This series adds an option for specifying the `recordsize`
through both the UI and `proxmox-backup-manager` when creating storage.
Since adding support for editing this property at the dataset level
would require more changes, I am sending the creation related
changes first. Support for editing the property will be send
as a separate series.
changes since v2: Thanks @Nicolas Frey
* Patch [3/3] - Instead of `if let-else` use `let-else` to match the
pattern.
* add {Reviewed,Tested}-by trailers.
changes since v1: Thanks @Nicolas Frey
* Patch [3/3] - Add validation function identical to the one in
Javscript to verify if the passed recordsize is valid. If it's not
valid, then the backup manager exits without creating the pool.
Earlier, even though the recordsize format was wrong, the backup
manager allowed executing the zpool and zfs commands, which in turn
created the pool with the default(128k) recordsize, but the
`zfs set` command failed with an error.
References:
- https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Workload%20Tuning.html#dataset-recordsize
proxmox-backup:
Shan Shaji (2):
partially fix #6933: ui: storage: add option to specify zfs recordsize
partially fix #6933: bin: add option to specify ZFS recordsize
src/api2/node/disks/zfs.rs | 14 +++++++++++--
src/bin/proxmox_backup_manager/disk.rs | 8 ++++++--
www/Utils.js | 28 ++++++++++++++++++++++++++
www/window/ZFSCreate.js | 8 ++++++++
4 files changed, 54 insertions(+), 4 deletions(-)
proxmox:
Shan Shaji (1):
pbs-api-types: zfs: define schema for recordsize
pbs-api-types/src/zfs.rs | 68 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
Summary over all repositories:
5 files changed, 122 insertions(+), 4 deletions(-)
--
Generated by murpp 0.10.0
next reply other threads:[~2026-08-12 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 14:40 Shan Shaji [this message]
2026-08-12 14:40 ` [PATCH proxmox-backup v3 1/3] partially fix #6933: ui: storage: add option to specify zfs recordsize Shan Shaji
2026-08-12 14:40 ` [PATCH proxmox-backup v3 2/3] partially fix #6933: bin: add option to specify ZFS recordsize Shan Shaji
2026-08-12 14:40 ` [PATCH proxmox v3 3/3] pbs-api-types: zfs: define schema for recordsize Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812144029.129970-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.