From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 37E171FF0E5 for ; Wed, 12 Aug 2026 14:07:56 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8458F21562; Wed, 12 Aug 2026 14:07:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aaroncarson.co.uk; s=google; t=1786536464; x=1787141264; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=aQ8/6PkNhnzeqq4XEaGf7BIqWh/wyFOB3jn1Omt8abk=; b=fa5u6iG2v7UVOvxu5/HaHNXpPre7gCCO0IgxS6j0ZfVaB/QdzZanQ4R0uGo7vEQ7+f COuMkuNPwOrIN0+GN8EOwj37FBJF2yC2zDkETOLQyrt+XhhtDp93KApOdLGOP1iEdqS8 QLtyMvlUudlFIqWVK0FSJ7y9NbDhhmGXWeut6kIbovUtDTOKPo33VEjsCsze0FPGvSaK mGm7f61EtTgWqZwc18RRKDvq9f5XSQ4cNLgVFBB5xWhbsyeqj5goCWTLOFXEQ76btWTI /LGqv2bEbO5/AuF3IBzBigmrdec/6Jl32n/Nx8Y3wRpGApIjyKn+9VVs1QXd4QeoXf1O nKEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786536464; x=1787141264; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aQ8/6PkNhnzeqq4XEaGf7BIqWh/wyFOB3jn1Omt8abk=; b=gFuDEQhxwYGsapnUN0Id40KXiFCYs4BGKtdubobbpr4bKsw2T10aTE6wxXKMjJN6vx 5bXen0YgfIAIMYEz0uT8ggK/ckw3KmvvfkIygMbST3K72kA5yV9UPXe4/7YG0tu+04Cx hn71HhybZdZjIZN4n+6L6IIOv8DAQm2BLZNaIuk7BxkFcE6JntwS4iA4eWbVoHny5Uyn U21XzTA26Nnesj1ckFcP85wadUJXsNmqqTkOnH9gKzvKYZI6FcgK37HLczY6DHQOiDmj vCKgPoaSVVn6htLJYlg+b82YK/JRdBJ7ZJBTJYR9XHOOiOdZ1gCIqTvF3yCq8XnJAn7V 3M4Q== X-Gm-Message-State: AOJu0Yz1n+qm9PmpMX5gknidkoEg0Q84qrpXcUMfRomV8Is+zcE1a3Xo 3ICbhom8X2IOqnyMzbWglgJqJ6gLUDqElPVSAAFFYWIxgXjDACMwugNPN6pU7wwk7RIK96UtKff HjO4OOjb/ofJ2hYW8sZratpAgUWoP3Q7WenczETsu5c3YyoK//sMz3Qln6UyBMyTw4SA4IX+S2c 9WaZtkoVEElwdhItBHsz4nglKvhNbh0zXiGnGYPb6k+ZxrQuuDQ3P5gIK+ X-Gm-Gg: AR+sD10IZqBGADc7rSC3M7+LFCr/BRGEajQy9++gXS7eWE5CXZxJLT8V/T23IGbQV2a PQUg6E/pAkuxsZgrJ8n2g4nxU3H1p3snscoFv7WAXGIq/C9c0Z2kZWt+q4LRhi2tEdyksbrhdZ2 Fm6YzXLAahaI7MafCZzmbK7RERZTHDOcmLRh6YxumwLux7WdEKvglIhtuLV5OXDPm+9lrzIA9cA 0ukgSRNOnBvI5t5/6fgh4Ng85tIk1bHS3QYOGIZiMJ233kuWZ7ep0bnOM6nQty7ASZJhhX9xBHk KmTyNZjsToITWIN3+f6J5AAyIXjFtGSorDYlhD5g1nEtY5la2o5UY/H3pmqezWLxbCvyBzqVPYN cSB2572IxhEEXJ3sku54mGftsR1fNHQYt/tYLkyRsNKdufN5hxmCmcM+rK7K3b0zsAyA9h4z7he Z5/OO7UJB8Jacf8A67/wH/+RgQpIYpurocUc3FO5oDv+IPnx4OgipCts5icwwoV7Z/iKkMg1WYD umRcPUEWgwyCknTOqMAFPW8xxxNOkrfCYrR4vLRsgGXF+QvQcY= X-Received: by 2002:a05:6000:2c13:b0:47f:7fe0:a287 with SMTP id ffacd0b85a97d-4815301b4cemr6439623f8f.2.1786536463329; Wed, 12 Aug 2026 05:07:43 -0700 (PDT) From: Aaron Carson To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-acme v2] acme: fix USER_AGENT variable interpolation in curl calls Date: Wed, 12 Aug 2026 12:02:28 +0000 Message-ID: <20260812120711.3626458-1-aaron@aaroncarson.co.uk> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy KAM_COUK 0.15 Scoring .co.uk emails higher due to poor registry security. RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EE2C37DK6EHEWNDXFJ4IM3V6HVKMBY62 X-Message-ID-Hash: EE2C37DK6EHEWNDXFJ4IM3V6HVKMBY62 X-MailFrom: aaron@aaroncarson.co.uk X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: aaron@aaroncarson.co.uk X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The variable was not interpolated, so ACME requests were sent with the literal string USER_AGENT as the user agent instead of the configured value. Signed-off-by: Aaron Carson --- Hi folks, resending with the correct subject prefix (v1 went out as [PATCH acme]). Noticed the user agent my DNS server was seeing when updating records for ACME was literally the string USER_AGENT - the variable isn't interpolated in the two _get_impl curl calls. My CLA is on file (office@ responded on 6th Aug). v2: correcting subject prefix, no code changes src/proxmox-acme | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/proxmox-acme b/src/proxmox-acme index 705f7df..39c770b 100644 --- a/src/proxmox-acme +++ b/src/proxmox-acme @@ -348,9 +348,9 @@ _get_impl() { _CURL="$_CURL --connect-timeout $t" fi if [ "$onlyheader" ]; then - $_CURL -I --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" + $_CURL -I --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" else - $_CURL --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" + $_CURL --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url" fi ret=$? if [ "$ret" != "0" ]; then -- 2.52.0