From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C74FC1FF0EA for ; Thu, 13 Aug 2026 17:59:24 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7528E21A5F; Thu, 13 Aug 2026 17:58:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azharul.com; s=t28hkp5; t=1786373278; x=1786978078; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/713KiXexCzeEUdcHf9F4+zgLnS7yVpGsBCy/nfC2ss=; b=mXb++8IQSbJO7qJzWjotV+lBPnblZTQxhTn06mf2s6p+2Hnkj+tmfuQjmsdp3YDa1F SPMFA2jztjXcoPqQRPscUqdW6grZyb3RbvWKyvS8dP/eCl+MDRcdEkJKgYXtEakY/6g1 RobbD9v+fSMmB4SirzjHuppCCZuJMHoS3S7Ufb87eHZ356xKCmxh0R3LdKvXxWJ7T4v+ QHdTwBAjAhFYucz1mu2Dv8TXwsDqr8OjDk66dx6evhnmFaYVnYaPUkMWSwqtxYSyCgxU vn0CyuHTA4xRo3qRyVQkoHBK6p4rhnMOoa2pzFVjBVWfw+kNCAwAxFeBRrOdj+BVcJ9V cvUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786373278; x=1786978078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/713KiXexCzeEUdcHf9F4+zgLnS7yVpGsBCy/nfC2ss=; b=CIJJVX//kEFNdB8eG1QdXuuKBNQVEEJr3qAkf9jV4FhT1l33M0srnlC1oiGxJuQFIh xmp4Uf7oVrgFmN0pIQNwx7s27PL1NiCY0XCyGu+33AUEURAvD4yhadue2PJadHrErLAC VVJb+4EWk3e/TWmqLQqJSZg69LZRBk80eCYi9Rvtpb0lF9PG19IxZzb785fsC3syRm1F Pbz4BvbHPURdoy8yxYJHecTzfCydRhgWROPumwrHg1vye9dXq44k6v+7truSdHKlbVBk MFKrM4e2en4rS5PjpqAifdWRZ+tnU8zDkAb7XLatJ6zYgOnayEWK3QpFZraaeMPKIEUN dM5g== X-Gm-Message-State: AOJu0Yy9dlg38BrkdORNV2QpWfOxyAk6EtcZcmQoEDCJb/fVrw+ibVt/ uzrZHwk/Ms7hdnjrnhW226tD2yzoIRwYFEFEzfpBhutCBPDVrERrJZQKq/XtHuCAfpxoaDF/OY1 osoRHgQ== X-Gm-Gg: AR+sD102bYC8OlFQQYCEWkip8tW7zHN9jdxp+upTCTiTaKOKFIqUNz/pgWGQWfmLGao XuFLj5wV1fSFlh3Hea8+qXlKnz8JahWKr9AncCDBjWTboZyOZCsJC/bJAszT19ii4ateaYgZGei 9hl5hlckSWUP8ueyghgkcwuKccD7pAc1Km9nNp6vTMkDv8C8TAvHXmRjnRpoHXIdU25O+ZHWMzg DoFK6i4ZDaN6or/yKipdHpGvT/GAwtQ3lHv2UJu3gpXYDym5gzuTn1lBH2hF0iG2LylylYSVZnP O2HbH6PzFTqVE+inwPm+79tjcSekCG2wPD7rToURN7i2rFgPIokzgsvzkUAk59xTLTCx2KzUsSP y9FDkvNa5g3wLrzyjmy52tdHE2N8hczkslL/i+WJOj0RwRKj8oxWvGntyUnCdJsSZNCTNGEmde0 2rqSY/5jk1pfOYWvFQVThcanzLDdj9bcp/ZxnhfPlK/OmrrFei/jqZGI32vf/bnuw5H+CyaAM+v lNRkIxBpiFvk8I/5qLsGjnZvjkkhd9eIIXTqeMl+WjPzuqH4AQAXou10UbhD8/DQ/8t3hz9rKU0 d1G4U9mM7KqZgL3go6RlSJIrtwENh9Uq7fZfB2yPsJ0lObcyIvT5TSp07SL952t/g+ExYADtuBL sXI6wB0xyueB9EIrmvrrjRuvdZrw= X-Received: by 2002:a05:620a:4084:b0:915:83f3:780d with SMTP id af79cd13be357-936665ad574mr3003820785a.32.1786373278565; Mon, 10 Aug 2026 07:47:58 -0700 (PDT) From: Azharul Haque To: pve-devel@lists.proxmox.com Subject: [PATCH login-manager v2 3/3] fix #4281: ui: use a namespaced OpenID callback scheme Date: Mon, 10 Aug 2026 10:47:11 -0400 Message-ID: <20260810144713.75806-6-haque@azharul.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260810144713.75806-1-haque@azharul.com> References: <20260810144713.75806-1-haque@azharul.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.163 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: haque@azharul.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: WM2WNBDRNHX4RIFVMTGWLZ5Y7H7F3PTQ X-Message-ID-Hash: WM2WNBDRNHX4RIFVMTGWLZ5Y7H7F3PTQ X-Mailman-Approved-At: Thu, 13 Aug 2026 17:58:30 +0200 CC: haque@azharul.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: pveauth:// worked in testing, but on Android a custom URL scheme isn't exclusively owned the way a verified App Link is: any other app installed on the device could in principle also declare an intent-filter for the same short, guessable scheme. Use com.proxmox.app.openid instead, derived from the app's own package/bundle identifier (com.proxmox.*, reserved for Proxmox on both app stores), so collisions with another app's scheme are effectively ruled out rather than merely unlikely. Signed-off-by: Azharul Haque --- lib/proxmox_login_form.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index 002838c..c5ea090 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -17,7 +17,11 @@ import 'package:proxmox_login_manager/proxmox_password_store.dart'; /// OpenID Connect login completes. Must be registered as a valid redirect /// URI with the realm's provider, as well as in the platform manifests /// (AndroidManifest.xml / Info.plist). -const String openIdCallbackScheme = 'pveauth'; +/// +/// Derived from the app's own package/bundle identifier (`com.proxmox.*`, +/// reserved for Proxmox on both app stores) rather than an arbitrary word, +/// so it can't collide with another app's custom URL scheme. +const String openIdCallbackScheme = 'com.proxmox.app.openid'; class ProxmoxProgressModel { int inProgress = 0; -- 2.50.1 (Apple Git-155)