From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 8D0101FF0EA for ; Thu, 13 Aug 2026 17:58:44 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BA08D219A6; Thu, 13 Aug 2026 17:58:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azharul.com; s=t28hkp5; t=1786373256; x=1786978056; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7evvHmV/gndfR1VqClnCmxIpoXrlTpHJxGPulC4y8m4=; b=GF0c0KiVYOL/2OrpxC+TSoHbLOBjPpvtzUVgHnXZjj4QKs8ER+quOque6uP/6tlFCQ x9mhn793RcLKK7e01reNdEd7POova6h1jtVfnza8j5TWPAV5NYn1POFpLfmv7BBmRnZX n0gKUxwYJ119javjsWURCRsvoWOgaFzHsdWfc1VBn5NE1FbiVzg/auGZGV21ziNz7SJw l51rwq8HA83sWvAdo7neZ9gW8WnbAU9uio186GfHOJTwH6WOt9M0U4d8Ev/yp3ltzzBY 9uHlQ05yeJD0cFoL63fvrJCB5vZRVeU/yocV/2l6IiRllpFHUF8CwV/da439ONPdCbXG 7LLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786373256; x=1786978056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7evvHmV/gndfR1VqClnCmxIpoXrlTpHJxGPulC4y8m4=; b=s8c4yGxXaPMsK/ISq12nzwpPQ4eCerAEraFnuzyYPWkLaGb48YkPoHFMWIXNaqIvnG 7OOnc2undBIRzenXDUYr6N5wd8ThEnKBiM+cdlzOn4RO1/VlVYTpDev+8hO/+YaJSi9r 8ggSKIVVii5yXfTvCoB2o1ipjdgaY+AXKWaIdWfndwp9HQTmNJxYuXqcRQRoaQZjUUxn NBOqL0/biqrjuIdf6YH/aZEHPLli0q6Ni0vM2iFrDnQJgV3syh9xFon0DrOpvIIZXubi FrJCa/3/qnCmy7P5fsaHfGWqqh5W8yfCdihkSMbDPN2ycwOCyprJEoHH6XxP1N4fLmiC 9DdQ== X-Gm-Message-State: AOJu0YzGj5dVmuCG4TwwrA4oKj0Lhf84gbf5bYjDzEtHng99p3lwDQ1b uCEEEqw9VykP3NcYEppImoF/brG7mGYrpIwZfRrJFW4qEVNv8Acy27ATk3A5vQy6e8Q6Sp1xgdd 3R6YtQg== X-Gm-Gg: AR+sD10+Z+KrJqE7e9UN5uXAt8cahKVt17jWEN3c/LGOvmzAx4L5/thJ4+XRsMRTFKh Kz88BaxzjnVvQb/ZMcjlf5NRLeglIzE16lAYnXd/X5IBgG5uLAf2ie9lFsV3erbJxFFFUu4A1gw v+61D/ziNzyOb5l2rku7tXc43H9xXR6/v3MTRIvmcebNqtGpJ3+BjowdZRDpGDD53mr0dSvrvUH +/tZH/zmZSz8TTs2af45beF+YbyUDjVe07ww7sUNNQ3gsi5jyIBYIpRXJqJXgIVSQ6ZIuzinmfj OKS3efkITPy2Gk+5uXuNeS92Ckly7fl7mToTT2cD3/D+pDxYiZAOq05tzlUwey3kop34hodAdvJ 5uxu8fLO2XSvh1Fx0RBtzQM/ESAWQs182IfbgRXJh26ouKF5aUPJydnt1mP5tlaBZOTH4d13GJA rKoZVwVWnO1ZEK/ggdNqdEYBY4DgDc0paSZ9r53yS3Q/l8rkBDv3rtcImlf22n5plVK1y1lA4lB f8nRLDOxyrOtQXVZbobTD5fTfvnQEOTRZgwmAYUWZCMxmlvqSZHzz6M4d3HtWkqdH+Byg+1rdB2 vClyfBxURd8Ulc0uEmfKpreWeZ0zgA05x3+9ydTTvZ0wgx4OoF+KOccvu9mQ0RDFZE5USd3gmbX Vq67J4ia4evzgutOCM2BZ/so/N2o= X-Received: by 2002:a05:620a:390b:b0:934:b6ba:15d5 with SMTP id af79cd13be357-936665d4fd1mr2908071985a.39.1786373255550; Mon, 10 Aug 2026 07:47:35 -0700 (PDT) From: Azharul Haque To: pve-devel@lists.proxmox.com Subject: [PATCH dart-api-client v2 1/2] fix #4281: access: add `type` property to `PveAccessDomainModel` Date: Mon, 10 Aug 2026 10:47:07 -0400 Message-ID: <20260810144713.75806-2-haque@azharul.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260810144713.75806-1-haque@azharul.com> References: <20260810144713.75806-1-haque@azharul.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.618 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy ENA_SUBJ_ODD_CASE 1.2 Subject has odd case POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: haque@azharul.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: OP3RCLKORAD5FQ6YDYOPQFOF6DO7QMJV X-Message-ID-Hash: OP3RCLKORAD5FQ6YDYOPQFOF6DO7QMJV X-Mailman-Approved-At: Thu, 13 Aug 2026 17:58:30 +0200 CC: haque@azharul.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The realm/domain list returned by /access/domains always includes a `type` field (pam, pve, ldap, ad, openid, ...), but the model never captured it. Without it, callers have no way to tell an OpenID Connect realm apart from a password-based one, which is why the login form falls back to showing username/password fields even for realms that require a browser-based OpenID login. Add the property and an `isOpenIdRealm` convenience getter, used by the login form in the following commits. Signed-off-by: Azharul Haque --- lib/src/models/pve_access_domain_model.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/models/pve_access_domain_model.dart b/lib/src/models/pve_access_domain_model.dart index 6298bbe..a2fff31 100644 --- a/lib/src/models/pve_access_domain_model.dart +++ b/lib/src/models/pve_access_domain_model.dart @@ -7,12 +7,14 @@ abstract class PveAccessDomainModel implements Built { // Fields String get realm; + String get type; String? get comment; String? get tfa; @BuiltValueField(wireName: 'default') int? get defaultValue; bool get isDefaultRealm => defaultValue == 1; + bool get isOpenIdRealm => type == 'openid'; PveAccessDomainModel._(); -- 2.50.1 (Apple Git-155)