From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C2C741FF0E1 for ; Mon, 10 Aug 2026 12:36:16 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 24E722162F; Mon, 10 Aug 2026 12:36:16 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2] fix #6211: ui: vm: options: add description to protection option Date: Mon, 10 Aug 2026 12:35:47 +0200 Message-ID: <20260810103547.73198-1-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786358159504 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.876 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XG5DZY23AJP2K4QJPAMYEVGAP4GEWZP3 X-Message-ID-Hash: XG5DZY23AJP2K4QJPAMYEVGAP4GEWZP3 X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The `Protection` option might be ambiguous for new users. Add a short description of the option in the same style as the options `Freeze CPU at startup` and `Start at boot`. Signed-off-by: Elias Huhsovitz --- changes v1 -> v2: * match style of existing options `Freeze CPU at startup` and `Start at boot`. * Reword commit message. v1: https://lore.proxmox.com/pve-devel/20260713114657.147881-1-e.huhsovitz@proxmox.com/ IMHO: The option should be renamed to something like `Prevent VM and disk removal`, instead of `Protection`. But this might confuse long term users as noted in [1]. Therefore i chose to simply update the label. [1] https://lore.proxmox.com/pve-devel/c5c7991a-919f-4ec4-a2e7-86f00d439149@proxmox.com/ www/manager6/lxc/Options.js | 5 ++++- www/manager6/qemu/Options.js | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index d475d4d8..c4521255 100644 --- a/www/manager6/lxc/Options.js +++ b/www/manager6/lxc/Options.js @@ -134,7 +134,10 @@ Ext.define('PVE.lxc.Options', { uncheckedValue: 0, defaultValue: 0, deleteDefaultValue: true, - fieldLabel: gettext('Enabled'), + labelWidth: Proxmox.Utils.compute_min_label_width( + gettext('Prevent VM and disk removal'), + ), + fieldLabel: gettext('Prevent VM and disk removal'), }, } : undefined, diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js index 8a4721a0..0ea4cb2d 100644 --- a/www/manager6/qemu/Options.js +++ b/www/manager6/qemu/Options.js @@ -325,7 +325,10 @@ Ext.define('PVE.qemu.Options', { uncheckedValue: 0, defaultValue: 0, deleteDefaultValue: true, - fieldLabel: gettext('Enabled'), + labelWidth: Proxmox.Utils.compute_min_label_width( + gettext('Prevent VM and disk removal'), + ), + fieldLabel: gettext('Prevent VM and disk removal'), }, } : undefined, -- 2.47.3