From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 736791FF0E1 for ; Mon, 10 Aug 2026 14:37:06 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 430292177F; Mon, 10 Aug 2026 14:36:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azharul.com; s=t28hkp5; t=1786340399; x=1786945199; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/713KiXexCzeEUdcHf9F4+zgLnS7yVpGsBCy/nfC2ss=; b=XNE9WoTlqlOnZNU1gtoAzze4RDnQuiCT8R1sewTdOkHCxQ+tc8jp2Uur047/sYVdUJ UiBvP8168cLDMqnsvRTqfr4e92N6l+z7OLG79am29BhsiAFxa1l8VTL3lBm4cONoC0/C GwFJUGFv9N4aNBJKMQ8kFEoskEio7iGTdaIflbndoM7aBv1H10lyFGfpqi3N3D1ZKnZx /G206QMHmWKHPnnXWMjYHa9Fw/G4elMB6WHiKSFrQZj1aTQPPqZWWfGdKlZsARy8kSSm nc1yoJlq8Cd9RpT5Rqz6h6zo/00ZRoodv1WDIpGq5YCCo2uc2Q1cRojYyAx6JJkA0925 oprA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786340399; x=1786945199; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/713KiXexCzeEUdcHf9F4+zgLnS7yVpGsBCy/nfC2ss=; b=M0eHu+eIbnW1NVglEGXhliTTfKyVL18Fwzugulj8YnVoBhT5EAjzib9qSSRRrPgaDT H6omTkkUDEnsh2rgofy/F67XrynT9ygz1DDrSlYSt7C1n3h4C1nkCN1tVLW0pcky2nl6 tEZRykgJuq1cSP1iOUMRbPgHUob9N21onORNS2ZR+Kv4gvLKOKvjxbrDasI2lxi1xqHo ngGIVKmPgWpsDkBii39ZkTwMlCE5Sdth0bed5C5L2jsy7ATJLxEG/nc9QOBQAdLb49eI 7W1qFOQeYC+79xSpnMQutTBrJBgi29N4qTvpaSnwZniI8SqyDwlXS9H+yO3gg29ZAvgi RuDQ== X-Gm-Message-State: AOJu0YypnlNXNVqj2dcoGuGu3+vPYHBaFnTIIAOCZM+7nTyzVreWbd+c PjE8PKTv89SgH22OUIWsbiUvhNetSqlNhjXAr21lCkjagEbR6/6H3DSfYyNxbGnaBMNuObzSDIr Fk7SAuw== X-Gm-Gg: AR+sD12NyPZb8WgLxQWdksng6tIF0Z24Xukoxg6Rsaum/Mom9PzquaEj3Cq/NtfZtDc xHXcQjUF+aZ8H7p4qFcKt/kjwYSqL93YCmCiEH1GnDsZs0xknyrsguLdmwclA9c+G2BJIUnKtPD +98klfOvYZhO3FNz21uDmZpp+zrP12SJ+jIvkDfn3rhha/HKBQ2q9FJYlfyzur1BF0hkngAHt8/ uWGuas1EG/Q6BZDH8N74p0RRrhP2J+zX7dVWHcbH0Kj+7/3OI8hiHkOMDDNxNanWAMBIip9bVyP z9OPdFKDlDekBd3oqZ3QqKFkdxNd040LYOFMNRU4xnAAgV5KN43OwKuXXoYQcIw/tIhnjvpua+V bF8k5QHBsB9z3kjnntw4FAoyTIb4D+3RFxCHdXv17KG+iL6RcRxRp+r//flEWDF5KYBJtJCWtuc I14WWOqiUy8YJoIsyITKD9mz/DqdgDEs8zkB6DmgmOsk7SnIi+PG/I8vto8qILpVAICecuAb6g8 yX+9TXxRPR+MoT7cyY6yaKnfq98bZEdQWBLdPaMKYbkXPbE6lvUlPUiBwWYhDN9hm6lHIXllxHv lZA9ni8j+5EDpz2e1b/yjpoRkoQX/8ctdXgu/gmyOFLDqfd72xAtdriTzNg/TNNPr7DJ3rkRLA0 MEaIeblLYb24KYyc+8aDfaH6EBK8= X-Received: by 2002:ae9:e917:0:b0:92e:612d:87cc with SMTP id af79cd13be357-93649167850mr3567574485a.46.1786340399583; Sun, 09 Aug 2026 22:39:59 -0700 (PDT) From: Azharul Haque To: pve-devel@lists.proxmox.com Subject: [PATCH 3/3] fix #4281: ui: use a namespaced OpenID callback scheme Date: Mon, 10 Aug 2026 01:39:41 -0400 Message-ID: <20260810053941.17000-4-haque@azharul.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260810053941.17000-1-haque@azharul.com> References: <20260810053941.17000-1-haque@azharul.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.196 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: haque@azharul.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: NPN7URGEFLXGLSZNGKMI3SPLNLMDNB76 X-Message-ID-Hash: NPN7URGEFLXGLSZNGKMI3SPLNLMDNB76 X-Mailman-Approved-At: Mon, 10 Aug 2026 14:36:15 +0200 CC: haque@azharul.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: pveauth:// worked in testing, but on Android a custom URL scheme isn't exclusively owned the way a verified App Link is: any other app installed on the device could in principle also declare an intent-filter for the same short, guessable scheme. Use com.proxmox.app.openid instead, derived from the app's own package/bundle identifier (com.proxmox.*, reserved for Proxmox on both app stores), so collisions with another app's scheme are effectively ruled out rather than merely unlikely. Signed-off-by: Azharul Haque --- lib/proxmox_login_form.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index 002838c..c5ea090 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -17,7 +17,11 @@ import 'package:proxmox_login_manager/proxmox_password_store.dart'; /// OpenID Connect login completes. Must be registered as a valid redirect /// URI with the realm's provider, as well as in the platform manifests /// (AndroidManifest.xml / Info.plist). -const String openIdCallbackScheme = 'pveauth'; +/// +/// Derived from the app's own package/bundle identifier (`com.proxmox.*`, +/// reserved for Proxmox on both app stores) rather than an arbitrary word, +/// so it can't collide with another app's custom URL scheme. +const String openIdCallbackScheme = 'com.proxmox.app.openid'; class ProxmoxProgressModel { int inProgress = 0; -- 2.50.1 (Apple Git-155)