From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 95C6A1FF0E1 for ; Mon, 10 Aug 2026 14:36:21 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3CDF3216B0; Mon, 10 Aug 2026 14:36:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azharul.com; s=t28hkp5; t=1786340285; x=1786945085; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7evvHmV/gndfR1VqClnCmxIpoXrlTpHJxGPulC4y8m4=; b=bDBCnYPt+Zs//aYUyd5In23fQYfoa6DEKC1IVncskwGhQx5OTmOjYmQQXU6X5m0L6z y3rgpqlnceBB3/XlB6DHYyqvB1vEjFxxgExpNRrt4A+MqXqB+xETHohc1y5xEAiKYiu2 Vliv52cI326p1lB5CuEYZVZraC5/cod2zX2bdFLkUyfVfjU1Q/EGWv8DbvkPJRd/nhmd IrqhLr/vh2/KMrsJb6cEJVanQhCWFtSRThUwseVnUg5xIHa9lDgkYWhnd2qYGo1foWUC yyq2YhsJqZC64UpdEdbOb33IK13loXmYI8hASu0UVeeYJyHao2K+YF6dRZE3WNtmsBV2 XFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786340285; x=1786945085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7evvHmV/gndfR1VqClnCmxIpoXrlTpHJxGPulC4y8m4=; b=VBNQ/A2aXP8PnmAEE0zJ6lRIN5rgsWtotmORpLuxLaBPDhnOy+qw+ONPqjTjyQw6ld ABwQQCxUwT3qjbVYvQExZfF3rhetW4M/3TTUyROn1p8ETR/ZnBFrChEzRWUCSbmqY5fR nz1l6XmIrH1Aa6H+Ijb1OZ9G2IahCc/ZlABJDT4KIuhonc3DXc6hCMDt8j++fgPtcdTZ oMn3ON065i+7HhO6ya3wY+06iLr22pzQ8DY73mBl7gZ98i6qqG9LZk/AGx2oburxE5RD rWamk3It345oAs8nbbXI6YoHaOruJasKkma7Gzakjfrw/+qxfug5l6YbbionQ31d/5P1 Mwyw== X-Gm-Message-State: AOJu0Yxm/1H1tSqqXdQEERGU/x3iEKRGszqcCHuf+VOx1izgHdPceni8 jTOk1KHol1UrfNO47gzpY14p8/DU2odHVqhQuPceRThXOwqVJkjmB2Xu20JGDrQmavRAwouKG08 NaMQ4nw== X-Gm-Gg: AR+sD13PUVevYtXdWghr/fAVHWy94h/BMcCB0mLMbg9MF0PdJNeGVYk0ozgrNiWnV2E sVVWQMBTqug4t4AdDyAvwqysioUEiZIKjOs4SVGFKzrMPJPpeSVAgXxGdk6kFHlL/x5SeguELbi z7Q67fT9j3SZh+oZkl7LnShfLeU/3maWhtJRBnEBLrAxh8gn7jBAEbaR2YIo72yODA+BjNySDEG CUN15iTbI4hkg9M/KEkdwMU9Zc1bwhHT2Q+L0vhK1k+0UEhIVSOkYsNfLHgJv8PuD5SyOw9hV/3 gPjiHuMjlXhpSTpZl/6Pk6BMnLEEf2WLVSdobPzq3Ob96TpeG1lunmrW0S3k5dRDihE9ZHZy8UX NyEfxldscZNz1XY9z28T5qjbx3wXt6UOayEc0+HzO+GAJ1JGjKmQgUkxpN8n+7+60zOngma7p7+ 5luvNoKj22jvcH26/1jv+OLOCL/uL/UtOSnNeo3aI2/oqiRM0vBsVy3DW0pevhHRf4VfZm2+4G6 1KLy2ePEx4mDbVHuhPw5XbGDbo5yTWWebxaFx6fZTm6ReveS5TksvczVRt+4vrnPRlVgrgcMA8y Z4aWeiAK62Tx9MgCV0wrQndOq1DzUUTwfjSbZIW3JKxSjoxxHzNKejhlRVYAAaNd18mG9MH/ioL SOfJtmtRbhdmfdabbMHY+gGnW3No= X-Received: by 2002:a05:620a:454f:b0:92e:eff7:34a4 with SMTP id af79cd13be357-936798eabafmr1690298485a.43.1786340284794; Sun, 09 Aug 2026 22:38:04 -0700 (PDT) From: Azharul Haque To: pve-devel@lists.proxmox.com Subject: [PATCH 1/2] fix #4281: access: add `type` property to `PveAccessDomainModel` Date: Mon, 10 Aug 2026 01:37:31 -0400 Message-ID: <20260810053732.16627-2-haque@azharul.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260810053732.16627-1-haque@azharul.com> References: <20260810053732.16627-1-haque@azharul.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.600 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy ENA_SUBJ_ODD_CASE 1.2 Subject has odd case POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: haque@azharul.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: 2NJAIVCGG2233LQH3HLI7454LFBFJURO X-Message-ID-Hash: 2NJAIVCGG2233LQH3HLI7454LFBFJURO X-Mailman-Approved-At: Mon, 10 Aug 2026 14:36:15 +0200 CC: haque@azharul.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The realm/domain list returned by /access/domains always includes a `type` field (pam, pve, ldap, ad, openid, ...), but the model never captured it. Without it, callers have no way to tell an OpenID Connect realm apart from a password-based one, which is why the login form falls back to showing username/password fields even for realms that require a browser-based OpenID login. Add the property and an `isOpenIdRealm` convenience getter, used by the login form in the following commits. Signed-off-by: Azharul Haque --- lib/src/models/pve_access_domain_model.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/models/pve_access_domain_model.dart b/lib/src/models/pve_access_domain_model.dart index 6298bbe..a2fff31 100644 --- a/lib/src/models/pve_access_domain_model.dart +++ b/lib/src/models/pve_access_domain_model.dart @@ -7,12 +7,14 @@ abstract class PveAccessDomainModel implements Built { // Fields String get realm; + String get type; String? get comment; String? get tfa; @BuiltValueField(wireName: 'default') int? get defaultValue; bool get isDefaultRealm => defaultValue == 1; + bool get isOpenIdRealm => type == 'openid'; PveAccessDomainModel._(); -- 2.50.1 (Apple Git-155)