From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E825E1FF0E0 for ; Thu, 06 Aug 2026 12:57:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6995221502; Thu, 06 Aug 2026 12:57:08 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH storage] fix: #7844: diskmanage: whitelist GRAID virtual block devices. Date: Thu, 6 Aug 2026 12:56:32 +0200 Message-ID: <20260806105632.91936-1-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786013806354 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.101 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EV6KTZ2ZWFBSX3FKTEL5MF5WO5C3YVBR X-Message-ID-Hash: EV6KTZ2ZWFBSX3FKTEL5MF5WO5C3YVBR X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Graid virtual drives are of format `gdgXnY`. This format is currently not whitelisted, resulting in the `Diskmanage::get_disks` subroutine to ignore the devices. Add regex to inlcude graid devices of format `gdgXnY`. Signed-off-by: Elias Huhsovitz --- Graid is propietary software. I current do not have access to any kind of authentic graid software or device. I tested this patch by creating a mock block device (e.g. gdg0n1) using a small kernel module. If there is a more robust version to test changes like this, please let me know. src/PVE/Diskmanage.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/Diskmanage.pm b/src/PVE/Diskmanage.pm index d9ce0d0..f3a34dc 100644 --- a/src/PVE/Diskmanage.pm +++ b/src/PVE/Diskmanage.pm @@ -562,10 +562,12 @@ sub get_disks { # - xvdX: xen virtual block device # - nvmeXnY: nvme devices # - cciss!cXnY cciss devices + # - gdgXnY: graid devices return if $dev !~ m/^(h|s|x?v)d[a-z]+$/ && $dev !~ m/^nvme\d+n\d+$/ - && $dev !~ m/^cciss\!c\d+d\d+$/; + && $dev !~ m/^cciss\!c\d+d\d+$/ + && $dev !~ m/^gdg\d+n\d+$/; my $data = get_udev_info("/sys/block/$dev") // return; my $devpath = $data->{devpath}; -- 2.47.3