From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 694591FF12C for ; Wed, 05 Aug 2026 15:19:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E35AF219A2; Wed, 05 Aug 2026 15:18:57 +0200 (CEST) From: Shannon Sterz To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v2 10/16] ui: wizard: nodes page: always update fingerprints on user confirmation Date: Wed, 5 Aug 2026 15:18:33 +0200 Message-ID: <20260805131838.254723-12-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260805131838.254723-2-s.sterz@proxmox.com> References: <20260805131838.254723-2-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785935919103 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.134 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KV2TAALUYWCBJ5WNWPZEILBF3PKVU3X3 X-Message-ID-Hash: KV2TAALUYWCBJ5WNWPZEILBF3PKVU3X3 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: if a user needs to confirm the fingerprint at this step, then the dialog had invalid fingerprints set. since we queried this information via at least one valid fingerprint from the remote itself, the most likely cause is an accident on the user's part. previously confirming the "Connection Certificate" dialog would only update the form, if no value was set for the fingerprint. after this change the values are always updated to the probed values. Signed-off-by: Shannon Sterz --- ui/src/remotes/wizard_page_nodes.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/remotes/wizard_page_nodes.rs b/ui/src/remotes/wizard_page_nodes.rs index 3428338d..a027c280 100644 --- a/ui/src/remotes/wizard_page_nodes.rs +++ b/ui/src/remotes/wizard_page_nodes.rs @@ -233,7 +233,7 @@ impl Component for PdmWizardPageNodes { { Ok(mut nodes) => { for node in nodes.iter_mut() { - if node.fingerprint.is_none() && map.contains_key(&node.hostname) { + if map.contains_key(&node.hostname) { node.fingerprint = Some(map.get(&node.hostname).unwrap().to_uppercase()); } -- 2.47.3