From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 0CD151FF0E3 for ; Tue, 04 Aug 2026 14:40:47 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3CED621730; Tue, 04 Aug 2026 14:40:45 +0200 (CEST) From: Shan Shaji To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox{-backup,} 0/3] partially fix #6933: add option to specify zfs recordsize Date: Tue, 4 Aug 2026 14:40:18 +0200 Message-ID: <20260804124021.83704-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785847226856 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6ZBIUMTBN446V2SUB26VVAJAEJG4BXTX X-Message-ID-Hash: 6ZBIUMTBN446V2SUB26VVAJAEJG4BXTX X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The option to specify the `recordsize` was previously available neither in the UI nor in the CLI. Users had to configure it manually using the ZFS CLI. This series adds an option for specifying the `recordsize` through both the UI and `proxmox-backup-manager` when creating storage. Since adding support for editing this property at the dataset level would require more changes, I am sending the creation related changes first. Support for editing the property will be send as a separate series. I am also trying to benchmark with different `recordsize` and `volblocksize` values on my host with an NVMe SSD. However, testing with multiple values (1m,2m adnd 4m) are taking longer, and I am bit unsure how meaningful the results would be because the test environment uses ZFS on top of ZFS. Therefore, I am sending this series for an initial review. The changes themselves are fairly straightforward. References: - https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Workload%20Tuning.html#dataset-recordsize proxmox-backup: Shan Shaji (2): partially fix #6933: ui: storage: add option to specify zfs recordsize partially fix #6933: bin: add option to specify ZFS recordsize src/api2/node/disks/zfs.rs | 14 +++++++++++-- src/bin/proxmox_backup_manager/disk.rs | 8 ++++++-- www/Utils.js | 28 ++++++++++++++++++++++++++ www/window/ZFSCreate.js | 8 ++++++++ 4 files changed, 54 insertions(+), 4 deletions(-) proxmox: Shan Shaji (1): pbs-api-types: zfs: define schema for recordsize pbs-api-types/src/zfs.rs | 5 +++++ 1 file changed, 5 insertions(+) Summary over all repositories: 5 files changed, 59 insertions(+), 4 deletions(-) -- Generated by murpp 0.10.0