all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage 0/7] iscsi: per-node target and portal configuration
Date: Tue,  4 Aug 2026 11:08:12 +0200	[thread overview]
Message-ID: <20260804090819.2136483-1-dietmar@proxmox.com> (raw)

Where every node reaches the same SAN through a different portal, and
sometimes through a different target, a single cluster-wide
portal/target pair is not enough. Patch 5 adds an 'iscsi-node-map'
property to the iSCSI storage: static target and portal entries, each
optionally restricted to a set of nodes. Entries without a node list
act as the default, so only the nodes that differ need one, and a node
can resolve to several targets, which allows multipath across
per-controller target names. Mapped entries skip sendtargets discovery
and sync the node db records directly, which also covers SANs that
filter discovery or do not implement it.

Patch 7 adds 'periodic-discovery'. Re-running discovery before every
login resets tuned node.* settings, so with periodic-discovery=0 it
only runs to seed an empty node db. The default keeps the current
behavior.

Patches 1 and 2 are independent bug fixes and stand on their own.
Patch 2 is Mira's idea, from patches 11 and 12 of [0].

There is no GUI for either property yet, both are API and CLI only.

[0] solves the same problem one level up, with a cluster-wide
mapping/storage.cfg, a plugin framework, a CRUD API and an ACL path,
and Thomas found that direction right at a high level. I still think
the inline property fits iSCSI better: a mapping cannot usefully be
shared, since every entry names a target, and it has to list every
node while this needs only the exceptions. 

[0] https://lore.proxmox.com/pve-devel/20260430173220.441001-1-m.limbeck@proxmox.com/

Dietmar Maurer (7):
  iscsi: discovery: do not stop early on a foreign target
  iscsi: scan: do not persist discovery results in the node database
  iscsi: validate target names with a dedicated format
  iscsi: clarify that the portal property is the discovery address
  iscsi: add iscsi-node-map property for per-node target and portals
  iscsi: iscsi_portals: return empty list instead of fallback portal
  iscsi: add periodic-discovery flag to skip re-discovery on login

 src/PVE/Storage.pm             |   2 +-
 src/PVE/Storage/ISCSIPlugin.pm | 369 +++++++++++++++++++++++++++++----
 2 files changed, 326 insertions(+), 45 deletions(-)

-- 
2.47.3




             reply	other threads:[~2026-08-04  9:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  9:08 Dietmar Maurer [this message]
2026-08-04  9:08 ` [PATCH storage 1/7] iscsi: discovery: do not stop early on a foreign target Dietmar Maurer
2026-08-04  9:08 ` [PATCH storage 2/7] iscsi: scan: do not persist discovery results in the node database Dietmar Maurer
2026-08-04  9:08 ` [PATCH storage 3/7] iscsi: validate target names with a dedicated format Dietmar Maurer
2026-08-04  9:08 ` [PATCH storage 4/7] iscsi: clarify that the portal property is the discovery address Dietmar Maurer
2026-08-04  9:08 ` [PATCH storage 5/7] iscsi: add iscsi-node-map property for per-node target and portals Dietmar Maurer
2026-08-04  9:08 ` [PATCH storage 6/7] iscsi: iscsi_portals: return empty list instead of fallback portal Dietmar Maurer
2026-08-04  9:08 ` [PATCH storage 7/7] iscsi: add periodic-discovery flag to skip re-discovery on login Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804090819.2136483-1-dietmar@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal