From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9A7261FF125 for ; Mon, 03 Aug 2026 11:08:28 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CF4BE21569; Mon, 03 Aug 2026 11:08:09 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v4 10/14] datastore: create lockdir with correct mode for backup user access Date: Mon, 3 Aug 2026 11:07:43 +0200 Message-ID: <20260803090747.265683-11-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260803090747.265683-1-c.ebner@proxmox.com> References: <20260803090747.265683-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785748074781 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.135 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NZAIF2OINONJQYY3QYUVTNFMBH2TRNDZ X-Message-ID-Hash: NZAIF2OINONJQYY3QYUVTNFMBH2TRNDZ X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since the helper can now also get called via the privileged api server, running as root, assure the base lock directories are created so user backup can access them. Signed-off-by: Christian Ebner --- pbs-datastore/src/lib.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/pbs-datastore/src/lib.rs b/pbs-datastore/src/lib.rs index 5e6dca4ab..c1d32903a 100644 --- a/pbs-datastore/src/lib.rs +++ b/pbs-datastore/src/lib.rs @@ -162,6 +162,8 @@ use std::path::Path; use anyhow::{Error, bail}; +use proxmox_sys::fs::CreateOptions; + use pbs_config::BackupLockGuard; /// Directory path where active operations counters are saved. @@ -262,7 +264,13 @@ where lock_dir = lock_dir.join(parent); }; - std::fs::create_dir_all(&lock_dir)?; + let backup_user = proxmox_product_config::get_api_user(); + let dir_create_options = CreateOptions::new() + .perm(nix::sys::stat::Mode::from_bits_truncate(0o755)) + .owner(backup_user.uid) + .group(backup_user.gid); + + proxmox_sys::fs::create_path(lock_dir, Some(dir_create_options), Some(dir_create_options))?; let lock = lock_fn(path)?; -- 2.47.3