[PATCH pve-storage 5/9] storage: expose plugin metadata in storage status

[Jakob Klocker <j.klocker@proxmox.com>]

The plugin state determined when scanning custom plugins was so far only
available internally. Add it to the per-storage information, together
with the API version the plugin implements, the API version range this
PVE supports, whether the plugin is provided by a third party, and the
optional plugin URL.

This allows the GUI to tell users that a storage uses an outdated or
broken plugin and to point them at the plugin's homepage.

Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
---
 src/PVE/API2/Storage/Status.pm | 39 ++++++++++++++++++++++++++++++++++
 src/PVE/Storage.pm             | 16 ++++++++++++++
 2 files changed, 55 insertions(+)

diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index 741d514..f044e7a 100644
--- a/src/PVE/API2/Storage/Status.pm
+++ b/src/PVE/API2/Storage/Status.pm
@@ -390,6 +390,45 @@ __PACKAGE__->register_method({
                 renderer => 'bytes',
                 optional => 1,
             },
+            plugin => {
+                description => "Metadata about the storage plugin backing this storage.",
+                type => 'object',
+                optional => 1,
+                properties => {
+                    external => {
+                        description =>
+                            "Set when the storage is provided by a third-party plugin.",
+                        type => 'boolean',
+                        optional => 1,
+                    },
+                    state => {
+                        description => "Plugin state: up-to-date, outdated, or load-error.",
+                        type => 'string',
+                        enum => ['up-to-date', 'outdated', 'load-error'],
+                        optional => 1,
+                    },
+                    'api-version' => {
+                        description => "API version implemented by the storage plugin.",
+                        type => 'integer',
+                        optional => 1,
+                    },
+                    'api-min' => {
+                        description => "Minimum plugin API version supported by this PVE.",
+                        type => 'integer',
+                        optional => 1,
+                    },
+                    'api-max' => {
+                        description => "Current plugin API version of this PVE.",
+                        type => 'integer',
+                        optional => 1,
+                    },
+                    url => {
+                        description => "URL to the plugin's homepage or documentation.",
+                        type => 'string',
+                        optional => 1,
+                    },
+                },
+            },
         },
     },
     code => sub {
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index b433efc..06be29d 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -1620,6 +1620,14 @@ sub storage_info {
         }
 
         my $type = $ids->{$storeid}->{type};
+        my $entry = custom_plugin_entry($type);
+        my $external = $entry ? 1 : 0;
+        my $state = get_plugin_state($type);
+        my $api_version = $entry ? $entry->{'api-version'} : APIVER;
+        my $plugin_url =
+            $entry
+            ? $entry->{'plugin-url'}
+            : eval { PVE::Storage::Plugin->lookup($type)->plugindata()->{'plugin-url'} };
 
         $info->{$storeid} = {
             type => $type,
@@ -1631,6 +1639,14 @@ sub storage_info {
                 PVE::Storage::Plugin::content_hash_to_string($ids->{$storeid}->{content}),
             active => 0,
             enabled => $storage_enabled ? 1 : 0,
+            plugin => {
+                external => $external,
+                state => $state,
+                'api-version' => $api_version,
+                'api-min' => (APIVER - APIAGE),
+                'api-max' => APIVER,
+                url => $plugin_url,
+            },
         };
     }
 
-- 
2.47.3