From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F21361FF0ED for ; Fri, 31 Jul 2026 12:23:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 523FB21501; Fri, 31 Jul 2026 12:22:07 +0200 (CEST) From: Dietmar Maurer To: pve-devel@lists.proxmox.com Subject: [RFC proxmox-widget-toolkit 15/27] disk selectors: allow opting into remote devices Date: Fri, 31 Jul 2026 12:21:44 +0200 Message-ID: <20260731102156.3947857-16-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260731102156.3947857-1-dietmar@proxmox.com> References: <20260731102156.3947857-1-dietmar@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -0.243 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: FBGEIW5WW54YQCEKTZIPDLWYSRIXSKTG X-Message-ID-Hash: FBGEIW5WW54YQCEKTZIPDLWYSRIXSKTG X-MailFrom: dietmar@zilli.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Generic disk selectors omit devices attached through known remote storage transports by default, because selecting them for node-local storage without an explicit opt-in is risky. Allow specialized callers to request the full list through the new includeRemoteDisks option. Signed-off-by: Dietmar Maurer --- src/form/DiskSelector.js | 8 ++++++++ src/form/MultiDiskSelector.js | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/src/form/DiskSelector.js b/src/form/DiskSelector.js index c2fb924..ec1f8de 100644 --- a/src/form/DiskSelector.js +++ b/src/form/DiskSelector.js @@ -11,6 +11,10 @@ Ext.define('Proxmox.form.DiskSelector', { // use include-partitions=1 as a parameter includePartitions: false, + // also list devices attached through a remote storage transport (for + // example FC, iSCSI, or NVMe over TCP), which the backend excludes by default + includeRemoteDisks: false, + // the property the backend wants for the type ('type' by default) typeProperty: 'type', @@ -60,6 +64,10 @@ Ext.define('Proxmox.form.DiskSelector', { extraParams['include-partitions'] = 1; } + if (me.includeRemoteDisks) { + extraParams['include-remote'] = 1; + } + var store = Ext.create('Ext.data.Store', { filterOnLoad: true, model: 'pmx-disk-list', diff --git a/src/form/MultiDiskSelector.js b/src/form/MultiDiskSelector.js index 50e819b..98402bc 100644 --- a/src/form/MultiDiskSelector.js +++ b/src/form/MultiDiskSelector.js @@ -27,6 +27,10 @@ Ext.define('Proxmox.form.MultiDiskSelector', { // add include-partitions=1 as a request parameter includePartitions: false, + // also list devices attached through a remote storage transport (for + // example FC, iSCSI, or NVMe over TCP), which the backend excludes by default + includeRemoteDisks: false, + disks: [], allowBlank: false, @@ -159,6 +163,10 @@ Ext.define('Proxmox.form.MultiDiskSelector', { if (me.includePartitions) { extraParams['include-partitions'] = 1; } + + if (me.includeRemoteDisks) { + extraParams['include-remote'] = 1; + } } me.disks = []; -- 2.47.3