From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 253BE1FF0E2 for ; Thu, 30 Jul 2026 15:32:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 87269214F9; Thu, 30 Jul 2026 15:32:05 +0200 (CEST) From: Shannon Sterz To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox 02/16] tls-certificates: add days_valid parameter to create_self_signed_cert Date: Thu, 30 Jul 2026 15:31:44 +0200 Message-ID: <20260730133158.418015-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260730133158.418015-1-s.sterz@proxmox.com> References: <20260730133158.418015-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785418312944 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.121 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YID5AM2APRK2NI6RZS7DR2CK7YGMNKXH X-Message-ID-Hash: YID5AM2APRK2NI6RZS7DR2CK7YGMNKXH X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: to allow specifying how long a certificate should be valid for. also adds unit tests to verify this behavior. Signed-off-by: Shannon Sterz --- Notes: imo, we could go down even more. as far as i am aware there is no real limit that is being enforced here for self-signed certificates from a browser perspective. they are already trusted on an exemption-basis anyway. however, certificates signed by public CAs will only be valid for a maximum of 47 days by 2029 [1]. hence, i would personally either adopt the same limit or go down to a year, as a sensible middle-ground. certificate rotation should really be automated even in self-signed scenarios. we also had cases in the past, where customers already ran into issue because they wanted to limit the lifetime of their certificates below 30 days [2]. meaning that there is a need out there for shorter lived certificates (though, in that case a custom CA & ACME setup was used). [1]: https://github.com/cabforum/servercert/pull/553 [2]: https://bugzilla.proxmox.com/show_bug.cgi?id=6372 proxmox-tls-certificates/src/util.rs | 132 ++++++++++++++++++++++++++- 1 file changed, 131 insertions(+), 1 deletion(-) diff --git a/proxmox-tls-certificates/src/util.rs b/proxmox-tls-certificates/src/util.rs index 2eac2252..8a822956 100644 --- a/proxmox-tls-certificates/src/util.rs +++ b/proxmox-tls-certificates/src/util.rs @@ -15,10 +15,13 @@ use crate::CertificateInfo; /// subject alternative names will be set based on this value. /// * `domain`: The optional domain which the node is in. If set, it will be appended to `nodename` /// to derive an FQDN as common and subject alternative name. +/// * `days_valid`: The optional amount of days that the certificate should be valid for. If not +/// set, the certificate will be valid for 3650 days, almost ten years. pub fn create_self_signed_cert( product_name: &str, nodename: &str, domain: Option<&str>, + days_valid: Option, ) -> Result<(PKey, X509), Error> { let rsa = Rsa::generate(4096).unwrap(); @@ -28,7 +31,7 @@ pub fn create_self_signed_cert( let today = openssl::asn1::Asn1Time::days_from_now(0)?; x509.set_not_before(&today)?; - let expire = openssl::asn1::Asn1Time::days_from_now(365 * 10)?; + let expire = openssl::asn1::Asn1Time::days_from_now(days_valid.unwrap_or(365 * 10))?; x509.set_not_after(&expire)?; let mut fqdn = nodename.to_owned(); @@ -207,3 +210,130 @@ fn asn1_time_to_unix(time: &openssl::asn1::Asn1TimeRef) -> Result { let mut c_tm = unsafe { c_tm.assume_init() }; proxmox_time::timegm(&mut c_tm) } + +#[cfg(test)] +mod test { + use super::*; + + fn get_self_signed_certificate_info( + product_name: &str, + nodename: &str, + domain: Option<&str>, + days_valid: Option, + ) -> CertificateInfo { + let cert = match create_self_signed_cert(product_name, nodename, domain, days_valid) { + Ok((_priv_key, certificate)) => certificate, + Err(e) => panic!("could not create self signed certificate - {e}"), + }; + + let pem_bytes = match cert.to_pem() { + Ok(pem) => pem, + Err(e) => panic!("could not get pem bytes from signed certificate - {e}"), + }; + + match CertificateInfo::from_pem("", &pem_bytes) { + Ok(cert_info) => cert_info, + Err(e) => panic!("could not parse cert pem to cert info - {e}"), + } + } + + #[test] + fn self_signed_certificate_correct_with_product_and_name_only() { + let cert_info = + get_self_signed_certificate_info("Proxmox Test Product", "name", None, None); + + assert!(cert_info.subject.contains("O = Proxmox Test Product")); + assert!(cert_info.subject.contains("CN = name")); + assert_eq!( + cert_info.san, + vec![ + "IP: [127, 0, 0, 1]", + "IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1]", + "DNS: localhost", + "DNS: name" + ] + ); + } + + #[test] + fn self_signed_certificate_correct_with_domain() { + let cert_info = + get_self_signed_certificate_info("Proxmox Test Product", "name", Some("fqdn"), None); + + assert!(cert_info.subject.contains("O = Proxmox Test Product")); + assert!(cert_info.subject.contains("CN = name.fqdn")); + assert_eq!( + cert_info.san, + vec![ + "IP: [127, 0, 0, 1]", + "IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1]", + "DNS: localhost", + "DNS: name", + "DNS: name.fqdn" + ] + ); + } + + #[test] + fn self_signed_certificate_correct_with_days_valid() { + let in_two_days = proxmox_time::epoch_i64() + 2 * 24 * 60 * 60; + let cert_info = + get_self_signed_certificate_info("Proxmox Test Product", "name", None, Some(2)); + + assert!( + cert_info + .notafter + .map(|a| a >= in_two_days) + .unwrap_or_default() + ); + assert!( + cert_info + .notafter + .map(|a| a < in_two_days + 24 * 60 * 60) + .unwrap_or_default() + ); + assert!(cert_info.subject.contains("O = Proxmox Test Product")); + assert!(cert_info.subject.contains("CN = name")); + assert_eq!( + cert_info.san, + vec![ + "IP: [127, 0, 0, 1]", + "IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1]", + "DNS: localhost", + "DNS: name", + ] + ); + } + + #[test] + fn self_signed_certificate_correct_with_domain_and_days_valid() { + let in_two_days = proxmox_time::epoch_i64() + 2 * 24 * 60 * 60; + let cert_info = + get_self_signed_certificate_info("Proxmox Test Product", "name", Some("fqdn"), Some(2)); + + assert!( + cert_info + .notafter + .map(|a| a >= in_two_days) + .unwrap_or_default() + ); + assert!( + cert_info + .notafter + .map(|a| a < in_two_days + 24 * 60 * 60) + .unwrap_or_default() + ); + assert!(cert_info.subject.contains("O = Proxmox Test Product")); + assert!(cert_info.subject.contains("CN = name.fqdn")); + assert_eq!( + cert_info.san, + vec![ + "IP: [127, 0, 0, 1]", + "IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1]", + "DNS: localhost", + "DNS: name", + "DNS: name.fqdn" + ] + ); + } +} -- 2.47.3