From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 690A31FF0E2 for ; Thu, 30 Jul 2026 15:18:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9F8B121507; Thu, 30 Jul 2026 15:17:52 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/8] block job: monitor: only print message that jobs are ready once Date: Thu, 30 Jul 2026 15:15:51 +0200 Message-ID: <20260730131613.157722-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260730131613.157722-1-f.ebner@proxmox.com> References: <20260730131613.157722-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785417458111 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.166 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QKKDQGMLJARPVY5IWAAG27EBI3KN5UMU X-Message-ID-Hash: QKKDQGMLJARPVY5IWAAG27EBI3KN5UMU X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: After issuing the QMP command for completion (i.e. complete or cancel), a job might still take a while to actually complete. Avoid printing the message that jobs are ready more than once. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/BlockJob.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm index 254d7906..0a51a65b 100644 --- a/src/PVE/QemuServer/BlockJob.pm +++ b/src/PVE/QemuServer/BlockJob.pm @@ -93,6 +93,7 @@ sub monitor { $op //= "mirror"; eval { + my $ready_message_printed; my $err_complete = 0; my $starttime = time(); @@ -160,7 +161,10 @@ sub monitor { last if scalar(keys %$jobs) == 0; if ($readycounter == scalar(keys %$jobs)) { - print "all '$op' jobs are ready\n"; + if (!$ready_message_printed) { + print "all '$op' jobs are ready\n"; + $ready_message_printed = 1; + } # do the complete later (or has already been done) last if $completion eq 'skip' || $completion eq 'auto'; -- 2.47.3