From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EF7DA1FF0E2 for ; Thu, 30 Jul 2026 15:18:54 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EF5E2215EE; Thu, 30 Jul 2026 15:17:54 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server 0/8] block job: monitor: improve completion handling and style Date: Thu, 30 Jul 2026 15:15:49 +0200 Message-ID: <20260730131613.157722-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785417457999 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.163 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NLCV7OFQ3CINEOSWA2MA5SFZCSO5U2Z4 X-Message-ID-Hash: NLCV7OFQ3CINEOSWA2MA5SFZCSO5U2Z4 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Avoid issuing duplicate completes and printing duplicate log messages when a job does not complete right away. This also avoids an unnecessary failure that could arise with bad timing. Avoid sleeping for a full second each time while waiting for completion to benefit migration. This partially solves #7854. Further, factor out the status printing from monitor(), clean up its signature and properly document it. qemu-server: Fiona Ebner (8): block job: monitor: avoid duplicate completion block job: monitor: only print message that jobs are ready once partially fix #7854: block job: monitor: handle completion faster to benefit migration block job: monitor: factor out job status printing block job: monitor: make operation argument non-optional block job: monitor: rename 'op' argument to 'operation' block job: monitor: pass options as a hash block job: monitor: properly document function src/PVE/QemuMigrate.pm | 5 +- src/PVE/QemuServer.pm | 14 +- src/PVE/QemuServer/BlockJob.pm | 168 +++++++++++++++------- src/PVE/QemuServer/VolumeChain.pm | 4 +- src/test/MigrationTest/QemuMigrateMock.pm | 2 +- 5 files changed, 131 insertions(+), 62 deletions(-) Summary over all repositories: 5 files changed, 131 insertions(+), 62 deletions(-) -- Generated by git-murpp 0.5.0