all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH manager v3 0/2] fix #6855: ui: storage: add mount options field for nfs, cifs, cephfs
Date: Thu, 30 Jul 2026 11:40:53 +0200	[thread overview]
Message-ID: <20260730094055.57659-1-e.huhsovitz@proxmox.com> (raw)

Setting custom mount options for NFS, CIFS and CephFS storage
requires users to use the CLI or edit `/etc/pve/storage.cfg`.
This series adds a new `Mount Options` text field allowing users to 
add custom mount options directly via the web interface. 

The field is located in the `Advanced` section of the edit window.

Bugzilla: https://bugzilla.proxmox.com/show_bug.cgi?id=6855

v2: https://lore.proxmox.com/pve-devel/20260723150316.168440-1-e.huhsovitz@proxmox.com/
v1: https://lore.proxmox.com/pve-devel/20260721121334.115027-1-e.huhsovitz@proxmox.com/

This version extends the UI update to CephFS for the sake of
completion, as the backend API already exposes the options
parameter for it. Additionally, it fixes a logic flaw where the
remount warning hint was incorrectly displayed when adding a
new storage.

Patch 1/2 add mount options field for NFS and CIFS.

Patch 2/2 add mount options field for CephFS.
This was not mentioned in the original bug report, but users have
encountered this issue before:
https://forum.proxmox.com/threads/storage-cephfs-and-multiple-file-systems-passing-options.55018/

Changes v2 -> v3:
- Extend the mount options UI field to CephFS for consistency,
  as the backend API already supports this parameter.
- Fix the dynamic hint logic to only display when editing an
  existing storage and the configuration is actively changed.
  This prevents the hint from showing unnecessarily during
  initial creation.
- Fix a typo in the commit message and harmonize formatting.

Changes v1 -> v2:
- Add a dynamic UI hint when a user changes the mount config
  or NFS version during an edit, informing them that a remount
  is required for changes to take effect.
- Update emptyText placeholders to align with existing Proxmox
  VE UI conventions.
- Add filtering of exact duplicate options (for example,
  "rdma, seal, rdma" becomes "rdma, seal").  Deep semantic
  deduplication (for example, "mount_timeout=60, mount_timeout=70")
  is omitted to preserve opaque mount options where such
  configurations might be desired by the underlying system.

  Note: This was already implemented in the v2 patch, but was
  accidentally omitted from the v1 -> v2 changelog.

Comments that have not been implemented:
- Automatic re-mount:
  Automatically triggering a remount could introduce
  unnecessary complexity and risk disrupting active I/O
  operations if a user modifies options while the storage is
  currently in use by running guests or backup jobs. If users
  need this functionality, it can be added in a separate,
  dedicated patch.

Big Thanks to Max for reviewing the previous versions!

Elias Huhsovitz (2):
  fix #6855: ui: storage: add mount options field for nfs amd smb/cifs
  ui: storage: add mount options field for cephfs

 www/manager6/storage/CIFSEdit.js   |  69 ++++++++++++++++--
 www/manager6/storage/CephFSEdit.js |  59 ++++++++++++++-
 www/manager6/storage/NFSEdit.js    | 112 +++++++++++++++++++++++------
 3 files changed, 210 insertions(+), 30 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-07-30  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30  9:40 Elias Huhsovitz [this message]
2026-07-30  9:40 ` [PATCH manager v3 1/2] fix #6855: ui: storage: add mount options field for nfs amd smb/cifs Elias Huhsovitz
2026-07-30  9:40 ` [PATCH manager v3 2/2] ui: storage: add mount options field for cephfs Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730094055.57659-1-e.huhsovitz@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal