From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D00A11FF0E4 for ; Tue, 28 Jul 2026 09:51:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 99A55214E3; Tue, 28 Jul 2026 09:51:35 +0200 (CEST) From: Erik Fastermann To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 1/2] ui: dc summary: update node grid fields in a single set() call Date: Tue, 28 Jul 2026 09:51:23 +0200 Message-ID: <20260728075124.53626-2-e.fastermann@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260728075124.53626-1-e.fastermann@proxmox.com> References: <20260728075124.53626-1-e.fastermann@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -0.266 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: YBIQ4LVHAY5KRCE3STXKYS6KZN5UUNFX X-Message-ID-Hash: YBIQ4LVHAY5KRCE3STXKYS6KZN5UUNFX X-MailFrom: efastermann@ruth.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Erik Fastermann X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Each set() call fires its own update event, so the grid redrew the row once per field. Passing all fields as an object fires a single event instead. The commit() call only served to clear the dirty flag, which the documented dirty option does directly, without emitting another update event per row. This is a refactor and should have no user-visible effect. Signed-off-by: Erik Fastermann --- www/manager6/dc/Summary.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js index bf7e99c6..cd4749be 100644 --- a/www/manager6/dc/Summary.js +++ b/www/manager6/dc/Summary.js @@ -164,12 +164,16 @@ Ext.define('PVE.dc.Summary', { if (gridstore.getById(data.id)) { let griditem = gridstore.getById(data.id); - griditem.set('cpuusage', data.cpu); let max = data.maxmem || 1; let val = data.mem || 0; - griditem.set('memoryusage', val / max); - griditem.set('uptime', data.uptime); - griditem.commit(); // else the store marks the field as dirty + griditem.set( + { + cpuusage: data.cpu, + memoryusage: val / max, + uptime: data.uptime, + }, + { dirty: false }, + ); } break; case 'storage': { -- 2.47.3