From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8C6941FF0E1 for ; Mon, 27 Jul 2026 16:35:23 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 322EA21509; Mon, 27 Jul 2026 16:35:15 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v3 08/17] all plugins, api: mark certain properties as advanced in plugindata() Date: Mon, 27 Jul 2026 16:34:32 +0200 Message-ID: <20260727143445.513900-9-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260727143445.513900-1-m.carrara@proxmox.com> References: <20260727143445.513900-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785162867418 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PIP54MNKY5U6EAQVXAVI2VRNQZ44NBGU X-Message-ID-Hash: PIP54MNKY5U6EAQVXAVI2VRNQZ44NBGU X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a new 'advanced-properties' hash in `plugindata()` of all plugins. For each plugin, mark every property that is used in the "Advanced" section of the create / edit panel in the UI in that hash. This results in the following properties being marked as advanced if they do appear in a given plugin's `properties()` or `options()`: - content-dirs - preallocation - snapshot-as-volume-chain Additionally, expose whether a property is advanced or not through a new 'x-advanced' key that is added to each plugin property schema that is returned by the plugins/storage/plugin endpoint. Signed-off-by: Max R. Carrara --- src/PVE/API2/Plugins/Storage/Plugin.pm | 3 +++ src/PVE/Storage/BTRFSPlugin.pm | 3 +++ src/PVE/Storage/CIFSPlugin.pm | 5 +++++ src/PVE/Storage/CephFSPlugin.pm | 3 +++ src/PVE/Storage/DirPlugin.pm | 5 +++++ src/PVE/Storage/ESXiPlugin.pm | 1 + src/PVE/Storage/ISCSIDirectPlugin.pm | 1 + src/PVE/Storage/ISCSIPlugin.pm | 1 + src/PVE/Storage/LVMPlugin.pm | 3 +++ src/PVE/Storage/LvmThinPlugin.pm | 1 + src/PVE/Storage/NFSPlugin.pm | 5 +++++ src/PVE/Storage/PBSPlugin.pm | 1 + src/PVE/Storage/RBDPlugin.pm | 1 + src/PVE/Storage/ZFSPlugin.pm | 1 + src/PVE/Storage/ZFSPoolPlugin.pm | 1 + 15 files changed, 35 insertions(+) diff --git a/src/PVE/API2/Plugins/Storage/Plugin.pm b/src/PVE/API2/Plugins/Storage/Plugin.pm index 665a376a..6f756506 100644 --- a/src/PVE/API2/Plugins/Storage/Plugin.pm +++ b/src/PVE/API2/Plugins/Storage/Plugin.pm @@ -74,6 +74,9 @@ my sub get_schema_for_plugin : prototype($) ($plugin) { # shallow copy my $property = { $prop_schema->%* }; + if (defined(my $props = $plugindata->{'advanced-properties'})) { + $property->{'x-advanced'} = defined($props->{$option}) ? 1 : 0; + } if (defined(my $props = $plugindata->{'sensitive-properties'})) { $property->{'x-sensitive'} = defined($props->{$option}) ? 1 : 0; } diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm index 6b2e09ad..feb72860 100644 --- a/src/PVE/Storage/BTRFSPlugin.pm +++ b/src/PVE/Storage/BTRFSPlugin.pm @@ -45,6 +45,9 @@ sub plugindata { { images => 1, rootdir => 1 }, ], format => [{ raw => 1, subvol => 1 }, 'raw'], + 'advanced-properties' => { + preallocation => 1, + }, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm index 23b505cd..38901536 100644 --- a/src/PVE/Storage/CIFSPlugin.pm +++ b/src/PVE/Storage/CIFSPlugin.pm @@ -125,6 +125,11 @@ sub plugindata { { images => 1 }, ], format => [{ raw => 1, qcow2 => 1, vmdk => 1 }, 'raw'], + 'advanced-properties' => { + 'content-dirs' => 1, + preallocation => 1, + 'snapshot-as-volume-chain' => 1, + }, 'sensitive-properties' => { password => 1 }, }; } diff --git a/src/PVE/Storage/CephFSPlugin.pm b/src/PVE/Storage/CephFSPlugin.pm index fcb8a9e6..c334a72b 100644 --- a/src/PVE/Storage/CephFSPlugin.pm +++ b/src/PVE/Storage/CephFSPlugin.pm @@ -118,6 +118,9 @@ sub plugindata { return { content => [{ vztmpl => 1, iso => 1, backup => 1, snippets => 1, import => 1 }, { backup => 1 }], + 'advanced-properties' => { + 'content-dirs' => 1, + }, 'sensitive-properties' => { keyring => 1 }, }; } diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm index cc52feae..d76a4308 100644 --- a/src/PVE/Storage/DirPlugin.pm +++ b/src/PVE/Storage/DirPlugin.pm @@ -38,6 +38,11 @@ sub plugindata { { images => 1, rootdir => 1 }, ], format => [{ raw => 1, qcow2 => 1, vmdk => 1, subvol => 1 }, 'raw'], + 'advanced-properties' => { + 'content-dirs' => 1, + preallocation => 1, + 'snapshot-as-volume-chain' => 1, + }, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index b5e4135e..cdc47958 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -31,6 +31,7 @@ sub plugindata { return { content => [{ import => 1 }, { import => 1 }], format => [{ raw => 1, qcow2 => 1, vmdk => 1 }, 'raw'], + 'advanced-properties' => {}, 'sensitive-properties' => { password => 1 }, }; } diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm b/src/PVE/Storage/ISCSIDirectPlugin.pm index f976c319..dfbde00a 100644 --- a/src/PVE/Storage/ISCSIDirectPlugin.pm +++ b/src/PVE/Storage/ISCSIDirectPlugin.pm @@ -66,6 +66,7 @@ sub plugindata { return { content => [{ images => 1, none => 1 }, { images => 1 }], select_existing => 1, + 'advanced-properties' => {}, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm index a35a9882..3a18925d 100644 --- a/src/PVE/Storage/ISCSIPlugin.pm +++ b/src/PVE/Storage/ISCSIPlugin.pm @@ -334,6 +334,7 @@ sub plugindata { return { content => [{ images => 1, none => 1 }, { images => 1 }], select_existing => 1, + 'advanced-properties' => {}, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index e254760a..d634f551 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -408,6 +408,9 @@ sub plugindata { return { content => [{ images => 1, rootdir => 1 }, { images => 1 }], format => [{ raw => 1, qcow2 => 1 }, 'raw'], + 'advanced-properties' => { + 'snapshot-as-volume-chain' => 1, + }, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm index 0f3b21d4..3c5e0c5c 100644 --- a/src/PVE/Storage/LvmThinPlugin.pm +++ b/src/PVE/Storage/LvmThinPlugin.pm @@ -32,6 +32,7 @@ sub type { sub plugindata { return { content => [{ images => 1, rootdir => 1 }, { images => 1, rootdir => 1 }], + 'advanced-properties' => {}, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/NFSPlugin.pm b/src/PVE/Storage/NFSPlugin.pm index e54c4a4a..8a85cd75 100644 --- a/src/PVE/Storage/NFSPlugin.pm +++ b/src/PVE/Storage/NFSPlugin.pm @@ -66,6 +66,11 @@ sub plugindata { { images => 1 }, ], format => [{ raw => 1, qcow2 => 1, vmdk => 1 }, 'raw'], + 'advanced-properties' => { + 'content-dirs' => 1, + preallocation => 1, + 'snapshot-as-volume-chain' => 1, + }, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index eb907aa3..73b6c1ee 100644 --- a/src/PVE/Storage/PBSPlugin.pm +++ b/src/PVE/Storage/PBSPlugin.pm @@ -31,6 +31,7 @@ sub type { sub plugindata { return { content => [{ backup => 1, none => 1 }, { backup => 1 }], + 'advanced-properties' => {}, 'sensitive-properties' => { 'encryption-key' => 1, 'master-pubkey' => 1, diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm index bf05f739..1d0f23e2 100644 --- a/src/PVE/Storage/RBDPlugin.pm +++ b/src/PVE/Storage/RBDPlugin.pm @@ -412,6 +412,7 @@ sub type { sub plugindata { return { content => [{ images => 1, rootdir => 1 }, { images => 1 }], + 'advanced-properties' => {}, 'sensitive-properties' => { keyring => 1 }, }; } diff --git a/src/PVE/Storage/ZFSPlugin.pm b/src/PVE/Storage/ZFSPlugin.pm index 7fef9303..60410cfa 100644 --- a/src/PVE/Storage/ZFSPlugin.pm +++ b/src/PVE/Storage/ZFSPlugin.pm @@ -176,6 +176,7 @@ sub type { sub plugindata { return { content => [{ images => 1 }, { images => 1 }], + 'advanced-properties' => {}, 'sensitive-properties' => {}, }; } diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm index 586578aa..5ac6d235 100644 --- a/src/PVE/Storage/ZFSPoolPlugin.pm +++ b/src/PVE/Storage/ZFSPoolPlugin.pm @@ -56,6 +56,7 @@ sub plugindata { return { content => [{ images => 1, rootdir => 1 }, { images => 1, rootdir => 1 }], format => [{ raw => 1, subvol => 1 }, 'raw'], + 'advanced-properties' => {}, 'sensitive-properties' => {}, }; } -- 2.47.3