From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E37C81FF0E0 for ; Thu, 23 Jul 2026 11:55:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2F9DA214C5; Thu, 23 Jul 2026 11:55:37 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v2 proxmox-backup 0/3] improve handling of bad S3 chunks during GC Date: Thu, 23 Jul 2026 11:54:08 +0200 Message-ID: <20260723095440.83690-1-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784800461290 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.217 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6PK26OASFU2MAXPRKWUHVBBHPLTI5Z5J X-Message-ID-Hash: 6PK26OASFU2MAXPRKWUHVBBHPLTI5Z5J X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changes since [v1]: * restricted visibility of new functions to pub(crate) [v1] https://lore.proxmox.com/pbs-devel/20260713132338.170565-1-r.obkircher@proxmox.com/ Robert Obkircher (3): datastore: fix local path for .i.bad chunk files during S3 GC datastore: check that .i.bad files from S3 actually match that pattern datastore: introduce helper function to parse digest from S3ObjectKey pbs-datastore/src/chunk_store.rs | 21 +++++++++++------ pbs-datastore/src/datastore.rs | 39 ++++++++------------------------ pbs-datastore/src/s3.rs | 39 +++++++++++++++++++++++++++++--- 3 files changed, 60 insertions(+), 39 deletions(-) -- 2.47.3