all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage] zfspool: export: fix regression with printing progress output
Date: Thu, 23 Jul 2026 10:50:37 +0200	[thread overview]
Message-ID: <20260723085132.29326-1-f.ebner@proxmox.com> (raw)

The progress from zfs send is printed to stderr, but the lines are
passed from run_command() to errfunc() without a trailing newline in
and so they would not show up in the task log right away, even with
the following call to flush. Use chomp() for future-proofing (e.g. if
there were an $errmsg, run_command() would call errfunc() with a
newline) and attach an explicit newline for each line passed to the
errfunc() to fix the issue.

Fixes: e0eb405 ("zfspool: export: skip hardcoded warning about no-preserve-encryption flag")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/Storage/ZFSPoolPlugin.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm
index 8630744..4c5b6c5 100644
--- a/src/PVE/Storage/ZFSPoolPlugin.pm
+++ b/src/PVE/Storage/ZFSPoolPlugin.pm
@@ -868,7 +868,8 @@ sub volume_export {
         errfunc => sub {
             my $line = shift;
             if ($line !~ /^WARNING: no-preserve-encryption flag set, sending dataset/) {
-                print STDERR $line;
+                chomp($line);
+                print STDERR "$line\n";
                 *STDERR->flush();
             }
         },
-- 
2.47.3





                 reply	other threads:[~2026-07-23  8:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723085132.29326-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal