From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 52CF51FF13A for ; Wed, 22 Jul 2026 10:48:35 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 910AF214AA; Wed, 22 Jul 2026 10:48:34 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3 06/16] ui: ha: node affinity: handle non-existent nodes Date: Wed, 22 Jul 2026 10:48:14 +0200 Message-ID: <20260722084824.108350-7-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260722084824.108350-1-d.kral@proxmox.com> References: <20260722084824.108350-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784710082680 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.132 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CWA2ZPFAYXZAQDBPBH3MDMAR3YGDTM4G X-Message-ID-Hash: CWA2ZPFAYXZAQDBPBH3MDMAR3YGDTM4G X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Though unlikely, the node in a HA node affinity rule could not exist in the store anymore. Therefore handle non-existent nodes by adding them to the store. Signed-off-by: Daniel Kral --- changes since v2: - none besides rebasing on the former www/manager6/ha/rules/NodeAffinityRuleEdit.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/www/manager6/ha/rules/NodeAffinityRuleEdit.js b/www/manager6/ha/rules/NodeAffinityRuleEdit.js index b1fdfde8..8c9f1a8b 100644 --- a/www/manager6/ha/rules/NodeAffinityRuleEdit.js +++ b/www/manager6/ha/rules/NodeAffinityRuleEdit.js @@ -101,13 +101,17 @@ Ext.define('PVE.ha.rules.NodeAffinityInputPanel', { nodenames.forEach(function (e, idx, array) { let [node, priority] = e.split(':'); - store.each(function (record) { - if (record.get('node') === node) { - sm.select(record, true); - record.set('priority', priority); - record.commit(); - } - }); + + let record = store.findRecord('node', node, 0, false, true, true); + if (record) { + record.set('priority', priority); + record.commit(); + } else { + let addedRecords = store.add({ node, priority }); + record = addedRecords[0]; + } + + sm.select(record, true); }); nodegrid.reconfigure(store); }; -- 2.47.3