[PATCH ha-manager 12/16] lrm: rename update_service_status to update_lrm_status

[Daniel Kral <d.kral@proxmox.com>]

update_lrm_status() is more fitting than update_service_status() here as
the internal LRM state that is updated by the information provided by
manager status does affect the whole LRM's behavior (node_status and
shutdown_request) and not only the LRM's behavior for its HA resources
(service_status).

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/PVE/HA/LRM.pm | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index bdf55d6e..920fda52 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -210,7 +210,19 @@ sub flush_lrm_status {
     return 1;
 }
 
-sub update_service_status {
+=head3 $self->update_lrm_status()
+
+Updates the internal LRM status properties to reflect the state given by the
+C<L<manager_status|PVE::HA::Env::read_manager_status()>>.
+
+The internal LRM status properties that are updated are C<node_status>,
+C<service_status>, and C<shutdown_request>.
+
+Returns 1 if the update was successful, otherwise returns undef.
+
+=cut
+
+sub update_lrm_status {
     my ($self) = @_;
 
     my $haenv = $self->{haenv};
@@ -224,7 +236,6 @@ sub update_service_status {
         my $nodename = $haenv->nodename();
         $self->{node_status} = $ms->{node_status}->{$nodename} || 'unknown';
 
-        # FIXME: method name is a bit confusing for doing this, either rename or move
         if (!$self->{shutdown_request}) {
             my $request = $ms->{node_request}->{$nodename} // {};
             if ($request->{maintenance}) {
@@ -378,7 +389,7 @@ sub work {
     my $status = $self->get_local_status();
     my $state = $status->{state};
 
-    $self->update_service_status();
+    $self->update_lrm_status();
 
     my $fence_request = $self->is_fence_requested();
 
@@ -509,7 +520,7 @@ sub work {
 
             # if we could not get the current service status there's no point
             # in doing anything, try again next round.
-            return if !$self->update_service_status();
+            return if !$self->update_lrm_status();
 
             if ($self->{shutdown_request}) {
 
@@ -608,7 +619,7 @@ sub work {
     } elsif ($state eq 'maintenance') {
 
         my $startime = $haenv->get_time();
-        return if !$self->update_service_status();
+        return if !$self->update_lrm_status();
 
         # wait until all active services moved away
         my $service_count = $self->active_service_count();
-- 
2.47.3