From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D68AD1FF138 for ; Mon, 20 Jul 2026 14:23:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4CCDF214AD; Mon, 20 Jul 2026 14:23:46 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] blockdev: recognize pflash devices on virt machines Date: Mon, 20 Jul 2026 14:23:32 +0200 Message-ID: <20260720122334.320518-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784550198021 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.143 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GNZ3MECXGRPBRXJ6UNHNV3R232OAMGW7 X-Message-ID-Hash: GNZ3MECXGRPBRXJ6UNHNV3R232OAMGW7 X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On ARM, QEMU's virt machine exposes EFI firmware pflash devices as '/machine/virt.flash0' and '/machine/virt.flash1'. The query-block mapping only recognized the x86-style '/machine/system.flash*' paths, so it failed to translate '/machine/virt.flash1' to 'efidisk0'. This made live cloning fail with 'no block node found for drive 'drive-efidisk0'.' Accept both system.flash* and virt.flash* paths for these devices. Signed-off-by: Lukas Sichert --- src/PVE/QemuServer/Blockdev.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer/Blockdev.pm b/src/PVE/QemuServer/Blockdev.pm index 101c747c..08a5acf8 100644 --- a/src/PVE/QemuServer/Blockdev.pm +++ b/src/PVE/QemuServer/Blockdev.pm @@ -72,9 +72,9 @@ sub qdev_id_to_drive_id { if ($qdev_id =~ m|^/machine/peripheral/(virtio(\d+))/virtio-backend$|) { return $1; - } elsif ($qdev_id =~ m|^/machine/system\.flash0$|) { + } elsif ($qdev_id =~ m{^/machine/(?:system|virt)\.flash0$}) { return 'pflash0'; - } elsif ($qdev_id =~ m|^/machine/system\.flash1$|) { + } elsif ($qdev_id =~ m{^/machine/(?:system|virt)\.flash1$}) { return 'efidisk0'; } -- 2.47.3