all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-i18n 2/7] make: simplify msgmerge commands
Date: Mon, 20 Jul 2026 13:13:36 +0200	[thread overview]
Message-ID: <20260720111343.353644-3-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260720111343.353644-1-m.sandoval@proxmox.com>

msgmerge has a --for-msgfmt which produces the same output ass filtering via
msgattrib. This removes the need for temporal files.

Some differences are that --for-msgfmt will also strip file location and
comments which do not serve any purpose when generating .mo files.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 Makefile | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/Makefile b/Makefile
index b233828b..dcd742ea 100644
--- a/Makefile
+++ b/Makefile
@@ -126,25 +126,21 @@ pbs-lang-%.js: %.po
 	./po2js.pl -t pbs -v "$(DEB_VERSION)" -o pbs-lang-$*.js $?
 
 catalog-%.mo: %.po messages.pot
-	msgmerge $*.po messages.pot | msgattrib --no-fuzzy --no-obsolete | msgfmt --verbose --output-file $@ $<;
+	msgmerge $*.po messages.pot --for-msgfmt | msgfmt --verbose --output-file $@ -
 
 .INTERMEDIATE: pve-yew-mobile-all.pot
 pve-yew-mobile-all.pot: pve-yew-mobile-gui.pot proxmox-yew-comp.pot proxmox-yew-widget-toolkit.pot
 	xgettext $^ --output $@
 
 pve-yew-mobile-catalog-%.mo: %.po pve-yew-mobile-all.pot
-	msgmerge $*.po pve-yew-mobile-all.pot| msgattrib --no-fuzzy --no-obsolete > $@.tmp
-	msgfmt --verbose --output-file $@ $@.tmp;
-	rm -rf  $@.tmp
+	msgmerge $*.po pve-yew-mobile-all.pot --for-msgfmt | msgfmt --verbose --output-file $@ -
 
 .INTERMEDIATE: pmg-yew-quarantine-all.pot
 pmg-yew-quarantine-all.pot: pmg-yew-quarantine-gui.pot proxmox-yew-comp.pot proxmox-yew-widget-toolkit.pot
 	xgettext $^ --output $@
 
 pmg-yew-quarantine-catalog-%.mo: %.po pmg-yew-quarantine-all.pot
-	msgmerge $*.po pmg-yew-quarantine-all.pot| msgattrib --no-fuzzy --no-obsolete > $@.tmp
-	msgfmt --verbose --output-file $@ $@.tmp;
-	rm -rf  $@.tmp
+	msgmerge $*.po pmg-yew-quarantine-all.pot --for-msgfmt | msgfmt --verbose --output-file $@ -
 
 # parameter 1 is the name
 # parameter 2 is the directory
-- 
2.47.3





  parent reply	other threads:[~2026-07-20 11:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 11:13 [PATCH proxmox-i18n 0/7] Makefile simplifications and improvements Maximiliano Sandoval
2026-07-20 11:13 ` [PATCH proxmox-i18n 1/7] make: catalog-%.mo: explicitly set template file Maximiliano Sandoval
2026-07-20 11:13 ` Maximiliano Sandoval [this message]
2026-07-20 11:13 ` [PATCH proxmox-i18n 3/7] make: clean: Cleanup *.mo files Maximiliano Sandoval
2026-07-20 11:13 ` [PATCH proxmox-i18n 3/7] make: clean: remove " Maximiliano Sandoval
2026-07-20 11:13 ` [PATCH proxmox-i18n 4/7] make: do_update: use long options for msgmerge Maximiliano Sandoval
2026-07-20 11:13 ` [PATCH proxmox-i18n 5/7] make: do_update: use --update " Maximiliano Sandoval
2026-07-20 11:13 ` [PATCH proxmox-i18n 6/7] make: add --previous flag to msgmerge Maximiliano Sandoval
2026-07-20 11:13 ` [PATCH proxmox-i18n 7/7] gitignore: remove proxmox-datacenter-manager.pot Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720111343.353644-3-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal