From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7B3331FF138 for ; Mon, 20 Jul 2026 11:47:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1EFC621509; Mon, 20 Jul 2026 11:47:18 +0200 (CEST) From: Erik Fastermann To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 2/3] partially fix #1989: ui: qemu: disk: add qcow2 cache size config Date: Mon, 20 Jul 2026 11:46:37 +0200 Message-ID: <20260720094638.113056-3-e.fastermann@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260720094638.113056-1-e.fastermann@proxmox.com> References: <20260720094638.113056-1-e.fastermann@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -0.086 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: MZNBBHQB4B2YZVXDHUU3LE47QDWILWQK X-Message-ID-Hash: MZNBBHQB4B2YZVXDHUU3LE47QDWILWQK X-MailFrom: efastermann@ruth.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Erik Fastermann X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add the option to control the size of the qcow2 cache in the vm disk create and edit dialogs. This can provide significant performance gains in some vm configurations. For a detailed explanation see the QEMU docs [0]. Currently only the cache-size is configurable in the frontend, either directly or based on the size of the disk. [0] https://gitlab.com/qemu-project/qemu/-/blob/master/docs/qcow2-cache.txt Signed-off-by: Erik Fastermann --- changes since v1: * simplified qcow2CacheSizeBasedOnDisk usage by binding the value (sadly the workaround for isQcow2 is still required) * added tooltips for the qcow2 cache options www/manager6/Parser.js | 2 +- www/manager6/qemu/HDEdit.js | 73 +++++++++++++++++++++++++++++++++++++ 2 files changed, 74 insertions(+), 1 deletion(-) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index 36df8e9d..f8d2bdad 100644 --- a/www/manager6/Parser.js +++ b/www/manager6/Parser.js @@ -207,7 +207,7 @@ Ext.define('PVE.Parser', { if (!p || p.match(/^\s*$/)) { return undefined; // continue } - let match = p.match(/^([a-z_]+)=(\S+)$/); + let match = p.match(/^([0-9a-z-]+)=(\S+)$/); if (!match) { if (!p.match(/[=]/)) { res.file = p; diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 1bb2bfda..fafa0f55 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -18,6 +18,8 @@ Ext.define('PVE.qemu.HDInputPanel', { isSCSI: false, isVirtIO: false, isSCSISingle: false, + isQcow2: false, + qcow2CacheSizeBasedOnDisk: false, }, }, @@ -54,6 +56,15 @@ Ext.define('PVE.qemu.HDInputPanel', { vm.set('isSCSISingle', value === 'virtio-scsi-single'); }, }, + 'field[name=diskformat]': { + change: 'onDiskFormatChange', + // afterrender is needed for setting the initial value + afterrender: 'onDiskFormatChange', + }, + }, + + onDiskFormatChange: function (field) { + this.getViewModel().set('isQcow2', field.getValue() === 'qcow2'); }, init: function (view) { @@ -88,6 +99,20 @@ Ext.define('PVE.qemu.HDInputPanel', { me.drive.format = values.diskformat; } + if (me.drive?.format === 'qcow2' || me.drive?.file?.endsWith('.qcow2')) { + if (values.qcow2CacheSize) { + me.drive['qcow2-cache-size'] = values.qcow2CacheSize; + } else { + delete me.drive['qcow2-cache-size']; + } + } + + PVE.Utils.propertyStringSet( + me.drive, + values.qcow2CacheSizeBasedOnDisk, + 'qcow2-cache-size-based-on-disk', + ); + PVE.Utils.propertyStringSet(me.drive, !values.backup, 'backup', '0'); PVE.Utils.propertyStringSet(me.drive, values.noreplicate, 'replicate', 'no'); PVE.Utils.propertyStringSet(me.drive, values.discard, 'discard', 'on'); @@ -156,6 +181,8 @@ Ext.define('PVE.qemu.HDInputPanel', { values.iothread = PVE.Parser.parseBoolean(drive.iothread); values.readOnly = PVE.Parser.parseBoolean(drive.ro); values.aio = drive.aio || '__default__'; + values.qcow2CacheSizeBasedOnDisk = drive['qcow2-cache-size-based-on-disk']; + values.qcow2CacheSize = drive['qcow2-cache-size']; values.mbps_rd = drive.mbps_rd; values.mbps_wr = drive.mbps_wr; @@ -167,6 +194,11 @@ Ext.define('PVE.qemu.HDInputPanel', { values.iops_wr_max = drive.iops_wr_max; me.setValues(values); + + me.getViewModel().set( + 'isQcow2', + values.diskformat === 'qcow2' || values.hdimage?.endsWith('.qcow2'), + ); }, setNodename: function (nodename) { @@ -355,6 +387,47 @@ Ext.define('PVE.qemu.HDInputPanel', { disabled: '{!isVirtIO && !isSCSI}', }, }, + { + xtype: 'numberfield', + name: 'qcow2CacheSize', + minValue: 1, + fieldLabel: gettext('qcow2 cache') + ' (MiB)', + emptyText: gettext('Default cache size'), + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Total size of the qcow2 cache in MiB. A larger cache can' + + ' improve I/O performance on large images. Leave empty to' + + ' use the QEMU default (32 MiB L2 cache and 256 KiB' + + ' refcount cache with the default disk settings).', + ), + }, + bind: { + disabled: '{!isQcow2 || qcow2CacheSizeBasedOnDisk}', + }, + listeners: { + disable: (field) => field.setValue(null), + }, + }, + { + xtype: 'proxmoxcheckbox', + name: 'qcow2CacheSizeBasedOnDisk', + defaultValue: 0, + fieldLabel: gettext('qcow2 cache based on disk'), + clearOnDisable: true, + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Automatically size the qcow2 cache to cover the whole disk.' + + ' Uses roughly 160 KiB of memory per GiB of disk with' + + ' the default disk settings.', + ), + }, + bind: { + value: '{qcow2CacheSizeBasedOnDisk}', + disabled: '{!isQcow2}', + }, + }, ); advancedColumn2.push( -- 2.47.3