From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC PATCH manager 3/4] ui: acl: expose the 'additive' ACL flag
Date: Thu, 16 Jul 2026 01:20:01 +0200 [thread overview]
Message-ID: <20260715232121.1009607-4-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20260715232121.1009607-1-t.lamprecht@proxmox.com>
Add an Additive checkbox to the add-permission dialog and a matching
column to the ACL grid so the flag can be set and seen from the web UI.
Additive requires propagate; tie the checkbox to Propagate (disabled
and cleared when Propagate is off) to mirror the API, which rejects
that combination.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
www/manager6/dc/ACLView.js | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/www/manager6/dc/ACLView.js b/www/manager6/dc/ACLView.js
index 7cc260e02..5091f7b53 100644
--- a/www/manager6/dc/ACLView.js
+++ b/www/manager6/dc/ACLView.js
@@ -61,6 +61,22 @@ Ext.define('PVE.dc.ACLAdd', {
checked: true,
uncheckedValue: 0,
fieldLabel: gettext('Propagate'),
+ listeners: {
+ // 'additive' requires 'propagate', so keep the checkbox in sync.
+ change: function (checkbox, value) {
+ let additive = checkbox.up('window').down('[name=additive]');
+ additive.setDisabled(!value);
+ if (!value) {
+ additive.setValue(false);
+ }
+ },
+ },
+ });
+ items.push({
+ xtype: 'proxmoxcheckbox',
+ name: 'additive',
+ uncheckedValue: 0,
+ fieldLabel: gettext('Additive'),
});
}
@@ -152,6 +168,12 @@ Ext.define(
sortable: true,
dataIndex: 'propagate',
});
+ columns.push({
+ header: gettext('Additive'),
+ width: 80,
+ sortable: true,
+ dataIndex: 'additive',
+ });
}
let sm = Ext.create('Ext.selection.RowModel', {});
@@ -264,6 +286,10 @@ Ext.define(
name: 'propagate',
type: 'boolean',
},
+ {
+ name: 'additive',
+ type: 'boolean',
+ },
],
});
},
base-commit: 20242970da7fbcef28aa6844d5d889319cb532ef
--
2.47.3
next prev parent reply other threads:[~2026-07-15 23:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 23:19 [RFC PATCH 0/4] add 'additive' flag to ACL entries Thomas Lamprecht
2026-07-15 23:19 ` [RFC PATCH access-control 1/4] acl: support 'additive' option on " Thomas Lamprecht
2026-07-15 23:20 ` [RFC PATCH access-control 2/4] api: acl: expose 'additive' flag via GET and PUT Thomas Lamprecht
2026-07-15 23:20 ` Thomas Lamprecht [this message]
2026-07-15 23:20 ` [RFC PATCH docs 4/4] pveum: document 'additive' ACL option Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715232121.1009607-4-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.