From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4FB371FF0E5 for ; Wed, 15 Jul 2026 13:09:06 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 81BE02143B; Wed, 15 Jul 2026 13:09:05 +0200 (CEST) Date: Wed, 15 Jul 2026 13:09:01 +0200 From: Stoiko Ivanov To: Stefan Hanreich Subject: Re: [PATCH pve-firewall v2 1/1] fix #7818: disallow vertical spaces in firewall comments Message-ID: <20260715130901.40d25fc1@rosa.proxmox.com> In-Reply-To: <20260715101054.31295-1-s.hanreich@proxmox.com> References: <20260715101054.31295-1-s.hanreich@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784113723337 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.250 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UOXZBSQKTDXX36X4GA6SF6TUTUMMBYZ4 X-Message-ID-Hash: UOXZBSQKTDXX36X4GA6SF6TUTUMMBYZ4 X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the quick iteration. gave it a minimal spin with a pvesh command i used to trigger the issue in #7818 - catches the new-line as expected. one nit inline - but with or without that: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Wed, 15 Jul 2026 12:10:53 +0200 Stefan Hanreich wrote: > They do not get sanitized and interpreted literally, allowing for > authenticated users to inject additional lines into the firewall > configuration files. Additionally restrict the comments to only > printable characters which additionally prevents control characters in > comments. > > Suggested-by: Stoiko Ivanov > Signed-off-by: Stefan Hanreich > --- > > Notes: > Changes from v1 (Thanks @Stoiko): > * disallow any vertical space instead of line feeds only > * additionally only allow printable characters > > Did quickly check the other properties as well, but couldn't find > anything. Will take a closer look still but wanted to get the patch > ready in the meanwhile. > > src/PVE/Firewall.pm | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index 93f8c34..8ec2b80 100644 > --- a/src/PVE/Firewall.pm > +++ b/src/PVE/Firewall.pm > @@ -1228,6 +1228,22 @@ sub pve_fw_verify_icmp_type_spec { > return $icmp_type; > } > > +PVE::JSONSchema::register_format('pve-fw-comment-spec', \&pve_fw_verify_comment_spec); > + > +sub pve_fw_verify_comment_spec { > + my ($comment) = @_; > + > + if ($comment =~ m/\p{VertSpace}/) { > + die "comment must not contain any line feeds\n"; nit: would read "line feed" as `\n` only - not general vertical space. but I think the message is expressive enough - and captures what went wrong. > + } > + > + if ($comment !~ m/^\p{Print}*$/) { > + die "comment must only contain printable characters\n"; > + } > + > + return $comment; > +} > + > # helper function for API > > sub copy_opject_with_digest { > @@ -1623,6 +1639,7 @@ my $rule_properties = { > description => "Descriptive comment.", > type => 'string', > optional => 1, > + format => 'pve-fw-comment-spec', > }, > 'icmp-type' => { > description =>