From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 646BD1FF0E4 for ; Tue, 14 Jul 2026 16:51:17 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0AA4F214C6; Tue, 14 Jul 2026 16:51:12 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH manager 3/3] api: nodes: use resolve_nodename helper for bulk operation Date: Tue, 14 Jul 2026 16:50:27 +0200 Message-ID: <20260714145027.53038-4-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260714145027.53038-1-e.huhsovitz@proxmox.com> References: <20260714145027.53038-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784040621551 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.336 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: A2J46E53D5WAXUBEJUGEI6O46XPHAHOC X-Message-ID-Hash: A2J46E53D5WAXUBEJUGEI6O46XPHAHOC X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The startall, stopall, and suspendall endpoints already contained inline logic to resolve the 'localhost' alias to the actual node name. Refactor these endpoints to use the new PVE::INotify::resolve_nodename() helper, improving consistency. Signed-off-by: Elias Huhsovitz --- PVE/API2/Ceph/MDS.pm | 3 +-- PVE/API2/Nodes.pm | 9 +++------ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Ceph/MDS.pm b/PVE/API2/Ceph/MDS.pm index 31b6fb7e..f9986d03 100644 --- a/PVE/API2/Ceph/MDS.pm +++ b/PVE/API2/Ceph/MDS.pm @@ -167,8 +167,7 @@ __PACKAGE__->register_method({ my $rpcenv = PVE::RPCEnvironment::get(); my $authuser = $rpcenv->get_user(); - my $nodename = $param->{node}; - $nodename = INotify::nodename() if $nodename eq 'localhost'; + my $nodename = PVE::INotify::resolve_nodename($param->{node}); my $mds_id = $param->{name} // $nodename; diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 90ce3c10..143da68a 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -2182,8 +2182,7 @@ __PACKAGE__->register_method({ } } - my $nodename = $param->{node}; - $nodename = PVE::INotify::nodename() if $nodename eq 'localhost'; + my $nodename = PVE::INotify::resolve_nodename($param->{node}); my $force = $param->{force}; @@ -2380,8 +2379,7 @@ __PACKAGE__->register_method({ } } - my $nodename = $param->{node}; - $nodename = PVE::INotify::nodename() if $nodename eq 'localhost'; + my $nodename = PVE::INotify::resolve_nodename($param->{node}); my $code = sub { @@ -2518,8 +2516,7 @@ __PACKAGE__->register_method({ } } - my $nodename = $param->{node}; - $nodename = PVE::INotify::nodename() if $nodename eq 'localhost'; + my $nodename = PVE::INotify::resolve_nodename($param->{node}); my $code = sub { -- 2.47.3