From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id C077D1FF0E4 for ; Tue, 14 Jul 2026 16:51:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 923432140A; Tue, 14 Jul 2026 16:51:11 +0200 (CEST) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH common 1/3] inotify: add helper to resolve 'localhost' node alias Date: Tue, 14 Jul 2026 16:50:25 +0200 Message-ID: <20260714145027.53038-2-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260714145027.53038-1-e.huhsovitz@proxmox.com> References: <20260714145027.53038-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784040621429 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.310 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BZHHVM4DX6OQRNBUIOMML5DU5GZRT3K6 X-Message-ID-Hash: BZHHVM4DX6OQRNBUIOMML5DU5GZRT3K6 X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Several API endpoints accept 'localhost' as a valid node alias via the API routing layer. However, the endpoint handlers often use the literal string 'localhost' to construct file paths in the cluster filesystem (e.g., /etc/pve/nodes/localhost/config), which fails because no actual node directory with that name exists. Add a PVE::INotify::resolve_nodename() helper to centralize the translation of 'localhost' to the actual node name. This ensures consistent behavior. across multiple API handlers. Signed-off-by: Elias Huhsovitz --- src/PVE/INotify.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 53b4e21..25ea0b8 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -533,6 +533,11 @@ sub nodename { return $cached_nodename; } +sub resolve_nodename { + my ($node) = @_; + return $node eq 'localhost' ? nodename() : $node; +} + sub read_etc_hostname { my ($filename, $fd) = @_; -- 2.47.3