From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 569411FF0E4 for ; Tue, 14 Jul 2026 11:05:05 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9C413213E5; Tue, 14 Jul 2026 11:05:04 +0200 (CEST) From: Thomas Ellmenreich To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-acme 0/1] fix #7749: always serialize in same order Date: Tue, 14 Jul 2026 11:04:57 +0200 Message-ID: <20260714090458.87511-1-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784019883651 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.407 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZXJCDAMQWVRR7AJ5WST3EVQVBC2F5GKB X-Message-ID-Hash: ZXJCDAMQWVRR7AJ5WST3EVQVBC2F5GKB X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Serializing acme responses to json, because of perls randomized hash key order, would lead to unequal serialized responses if they were compared as bytes. By setting "canonical => 1" the serializations now always have the same order and can thus be compared bytewise. I have tested the patch against a local instance of HashiCorp Vault PKI and the EAB registration works. It seems that "canonical" can have performance implications when serialising larger objects, but since the objects produced in our acme client are relatively small, I consider this acceptable. proxmox-acme: Thomas Ellmenreich (1): fix #7749: always serialize in same order src/PVE/ACME.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Summary over all repositories: 1 files changed, 4 insertions(+), 4 deletions(-) -- Generated by murpp 0.12.0