From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1D2E91FF0E1 for ; Mon, 13 Jul 2026 13:42:45 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3779321497; Mon, 13 Jul 2026 13:42:40 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [RFC PATCH pve-manager 0/2] add reload/upload buttons to iso selector Date: Mon, 13 Jul 2026 13:36:58 +0200 Message-ID: <20260713114205.2382258-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.390 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WDMTXMCHOQMQMMR3IX6KJXWU2Y6QMW5U X-Message-ID-Hash: WDMTXMCHOQMQMMR3IX6KJXWU2Y6QMW5U X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: It often happens that one forgot to upload an iso before starting the vm wizard. instead of having to navigate to the storage and upload there, add an inline upload button to the create wizard. Using this space, we can add a general 'reload' button which reloads the storage list as well as the file list for the selected storage. Sending this as RFC for multiple reasons: * This shows a modal window over another (upload over wizard), which is a pattern we don't usually use. IMO it's fine here since it's a rather minor use case, but still. * Placement of the buttons: I tried with inline buttons as well as 'triggers', but both have serious disadvantages: - inline buttons: don't count to the field width and it's hard with extjs' layout to achieve a consistent size for storage and file selector - triggers: we'd have to handroll the svg/png images (like pmx-clear), and i'm not very good with svgs in general. I tried to extract the font-awesome icons into standalone svgs, but could not get a result that was good enough (for me). Maybe someone else has more luck with that? Aside from the icons this has another problem: it makes the file selector content very narrow when there are multiple triggers and the user might not see what is actually selected. Dominik Csapak (2): ui: iso selector: add 'reload' button ui: iso selector: add 'upload' button in the create VM wizard www/manager6/form/FileSelector.js | 12 +++++ www/manager6/form/IsoSelector.js | 75 ++++++++++++++++++++++++++++ www/manager6/form/StorageSelector.js | 11 +++- www/manager6/qemu/CDEdit.js | 1 + www/manager6/qemu/OSPanel.js | 1 + 5 files changed, 98 insertions(+), 2 deletions(-) -- 2.47.3