From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8E6071FF0E1 for ; Mon, 13 Jul 2026 11:50:48 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5E9292139E; Mon, 13 Jul 2026 11:50:48 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v2 05/15] task cache: add test case for task cache rotation Date: Mon, 13 Jul 2026 11:49:27 +0200 Message-ID: <20260713094937.151838-6-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260713094937.151838-1-l.wagner@proxmox.com> References: <20260713094937.151838-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783936169152 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.294 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NUPJCHNWLLXQZT6A23YXQSO7I2XLG3HV X-Message-ID-Hash: NUPJCHNWLLXQZT6A23YXQSO7I2XLG3HV X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is to ensure that older files are indeed compressed and then later removed. Signed-off-by: Lukas Wagner --- Notes: Changes since v1: - clippy fix: don't use assert_eq! to compare booleans server/src/remote_tasks/task_cache.rs | 66 +++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/server/src/remote_tasks/task_cache.rs b/server/src/remote_tasks/task_cache.rs index 55aa8b70..95fe58e1 100644 --- a/server/src/remote_tasks/task_cache.rs +++ b/server/src/remote_tasks/task_cache.rs @@ -1555,4 +1555,70 @@ mod tests { assert_eq!(cache.get_tasks(GetTasks::Active).unwrap().count(), 0); assert_eq!(cache.get_tasks(GetTasks::Archived).unwrap().count(), 3); } + + #[test] + #[allow(clippy::get_first)] + fn archive_file_rotation() { + let (_tmp_dir, mut cache) = make_cache().unwrap(); + cache.rotate_after = 100; + cache.uncompressed_files = 1; + cache.max_files = 2; + + let cache = cache.write().unwrap(); + cache.init(1000).unwrap(); + + add_tasks(&cache, vec![task(1010, Some(1011)), task(1020, Some(1021))]).unwrap(); + cache.apply_journal().unwrap(); + + cache.rotate(1100).unwrap(); + + let files = cache.cache.archive_files(&cache.lock).unwrap(); + assert_eq!(files.len(), 2); + let first = files.get(0).unwrap(); + let second = files.get(1).unwrap(); + + assert!(!first.compressed); + assert_eq!(first.starttime, 1100); + assert!(second.compressed); + assert_eq!(second.starttime, 1000); + + assert_eq!(first.iter().unwrap().unwrap().count(), 0); + assert_eq!(second.iter().unwrap().unwrap().count(), 2); + + add_tasks(&cache, vec![task(1110, Some(1111))]).unwrap(); + cache.apply_journal().unwrap(); + + cache.rotate(1200).unwrap(); + + add_tasks(&cache, vec![task(1210, Some(1211))]).unwrap(); + cache.apply_journal().unwrap(); + + let files = cache.cache.archive_files(&cache.lock).unwrap(); + assert_eq!(files.len(), 2); + let first = files.get(0).unwrap(); + let second = files.get(1).unwrap(); + + assert!(!first.compressed); + assert_eq!(first.starttime, 1200); + assert!(second.compressed); + assert_eq!(second.starttime, 1100); + + assert_eq!(first.iter().unwrap().unwrap().count(), 1); + assert_eq!(second.iter().unwrap().unwrap().count(), 1); + + cache.rotate(1300).unwrap(); + + let files = cache.cache.archive_files(&cache.lock).unwrap(); + assert_eq!(files.len(), 2); + let first = files.get(0).unwrap(); + let second = files.get(1).unwrap(); + + assert!(!first.compressed); + assert_eq!(first.starttime, 1300); + assert!(second.compressed); + assert_eq!(second.starttime, 1200); + + assert_eq!(first.iter().unwrap().unwrap().count(), 0); + assert_eq!(second.iter().unwrap().unwrap().count(), 1); + } } -- 2.47.3