From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 533CB1FF0F6 for ; Sat, 11 Jul 2026 07:03:45 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 94D3121438; Sat, 11 Jul 2026 07:03:44 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: Re: [PATCH manager 2/2] ceph: osd: stop running pveremove during cleanup Date: Sat, 11 Jul 2026 13:03:23 +0800 Message-ID: <20260711050323.2573136-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260317123343.299525-3-m.sandoval@proxmox.com> References: <20260317123343.299525-1-m.sandoval@proxmox.com> <20260317123343.299525-3-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783746197565 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OAHP6NPMH6GD5RTR6X4SAVVQ3QXYNFPI X-Message-ID-Hash: OAHP6NPMH6GD5RTR6X4SAVVQ3QXYNFPI X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Verified: 7f007e7fc added api.remove_pv() to zap.py, so 'ceph-volume lvm zap --destroy' drops the PV itself. It is in every Ceph release available for PVE 9, so the pvremove here is redundant. Two nits: the message says Reef is the oldest supported Ceph in PVE 9, but per PVE/Ceph/Releases.pm that is Squid (19.2), Reef is PVE 8 only. Does not change the conclusion, 7f007e7fc is in Squid too. And the subject reads 'pveremove', which looks like a typo of 'pvremove'. Reviewed-by: Kefu Chai