From: Jakob Klocker <j.klocker@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Jakob Klocker <j.klocker@proxmox.com>
Subject: [PATCH proxmox-backup 0/2] fix #6990: server: drop verify state on push & pull job
Date: Thu, 9 Jul 2026 14:21:33 +0200 [thread overview]
Message-ID: <20260709122136.352839-1-j.klocker@proxmox.com> (raw)
When syncing a snapshot to another datastore, the source's verify_state is
currently carried over to the target. This reports the target snapshot as
verified even though its stored copy was never checked there. Since verify
jobs skip snapshots that already carry a verify_state, the target's copy
can't be verified again.
Chunks are checksummed in memory while being transferred, but a verify
serves a different purpose: confirming the write to the (external) target
actually succeeded.
This series drops verify_state on sync so the target is verified
independently. The state is dropped by default.
Tested (verify_state correctly stripped on target):
* Pull, verified source, new content, clean sync
* Pull, verified source, existing content, clean sync
* Pull, corrupted target, resync-corrupt
* Push, verified source (has no corrupt path)
* Pull, independently-verified target, clean re-sync - state preserved
Link: https://bugzilla.proxmox.com/show_bug.cgi?id=6990
proxmox-backup:
Jakob Klocker (2):
fix #6990: server: drop verify state on non-decrypt pull job
fix #6990: server: drop verify state on push job
src/server/pull.rs | 42 ++++++++++++++++++++++++++++--------------
src/server/push.rs | 6 ++++++
2 files changed, 34 insertions(+), 14 deletions(-)
Summary over all repositories:
2 files changed, 34 insertions(+), 14 deletions(-)
--
Generated by murpp 0.12.0
next reply other threads:[~2026-07-09 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 12:21 Jakob Klocker [this message]
2026-07-09 12:21 ` [PATCH proxmox-backup 1/2] fix #6990: server: drop verify state on non-decrypt pull job Jakob Klocker
2026-07-09 12:21 ` [PATCH proxmox-backup 2/2] fix #6990: server: drop verify state on push job Jakob Klocker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709122136.352839-1-j.klocker@proxmox.com \
--to=j.klocker@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.